From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.mail.elte.hu (mx2.mail.elte.hu [157.181.151.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3C60CDDD0B for ; Mon, 9 Feb 2009 20:40:35 +1100 (EST) Date: Mon, 9 Feb 2009 10:40:14 +0100 From: Ingo Molnar To: Steven Rostedt Subject: Re: [PATCH] ftrace, powerpc64: fix math to calculate offset in TOC Message-ID: <20090209094014.GE7930@elte.hu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: Arnd Bergmann , LKML , linuxppc-dev@ozlabs.org, Paul Mackerras , Remis Lima Baima List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , * Steven Rostedt wrote: > > Paul, > > I found the bug that was causing large modules to fail in setting > up dynamic ftrace. It wound up being a simple math error. To calculate > the offset in the TOC, I had used an OR, but the bottom half was > a signed extended short, and it should have been an addition. > The fix is in my tree below, as well as posted here. Looks like a .29 candidate? Ingo