From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Remis Lima Baima <remis.developer@googlemail.com>
Subject: Re: [PATCH] ftrace, powerpc64: fix math to calculate offset in TOC
Date: Mon, 9 Feb 2009 16:24:24 +0100 [thread overview]
Message-ID: <20090209152424.GA9845@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0902091000400.14528@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Mon, 9 Feb 2009, Ingo Molnar wrote:
>
> >
> > * Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > >
> > > Paul,
> > >
> > > I found the bug that was causing large modules to fail in setting
> > > up dynamic ftrace. It wound up being a simple math error. To calculate
> > > the offset in the TOC, I had used an OR, but the bottom half was
> > > a signed extended short, and it should have been an addition.
> > > The fix is in my tree below, as well as posted here.
> >
> > Looks like a .29 candidate?
>
> Ingo,
>
> I think Ben pulled them into their tree. The changes are specific to ppc,
> and will probably get better user testing there. Unless you feel that we
> have a bit of ppc testers using tip.
no, that's fine - just wanted to make sure it goes upstream via some method.
Ingo
next prev parent reply other threads:[~2009-02-09 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 6:22 [PATCH] ftrace, powerpc64: fix math to calculate offset in TOC Steven Rostedt
2009-02-09 9:40 ` Ingo Molnar
2009-02-09 13:08 ` Remis Lima Baima
2009-02-09 15:02 ` Steven Rostedt
2009-02-09 15:24 ` Ingo Molnar [this message]
2009-02-09 22:21 ` Benjamin Herrenschmidt
2009-02-09 20:16 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209152424.GA9845@elte.hu \
--to=mingo@elte.hu \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=remis.developer@googlemail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).