From: Jean Delvare <khali@linux-fr.org>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, linux-i2c@vger.kernel.org,
Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete
Date: Tue, 10 Feb 2009 16:55:54 +0100 [thread overview]
Message-ID: <20090210165554.0da8bf7c@hyperion.delvare> (raw)
In-Reply-To: <ed82fe3e0902100659p2eec9de6j61f9ffb504d60a89@mail.gmail.com>
On Tue, 10 Feb 2009 08:59:57 -0600, Timur Tabi wrote:
> On Fri, Feb 6, 2009 at 8:00 AM, Timur Tabi <timur@freescale.com> wrote:
> > The i2c_wait() function is using wait_event_interruptible_timeout() to wait for
> > the I2C controller to signal that it has completed an I2C bus operation. If
> > the process that causes the I2C operation terminated abruptly, the wait will
> > be interrupted, returning an error. It is better to let the I2C operation
> > finished before the process exits.
> >
> > It is safe to use wait_event_timeout() instead, because the timeout will allow
> > the process to exit if the I2C bus hangs. It's also better to allow the
> > I2C operation to finish, because unacknowledged I2C operations can cause the
> > I2C bus to hang.
> >
> > Signed-off-by: Timur Tabi <timur@freescale.com>
>
> Jean,
>
> Could you pick up this patch for 2.6.30?
No, that's something for either Ben Dooks (Cc'd) or the powerpc tree.
--
Jean Delvare
next prev parent reply other threads:[~2009-02-10 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 14:00 [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete Timur Tabi
2009-02-10 14:59 ` Timur Tabi
2009-02-10 15:55 ` Jean Delvare [this message]
2009-02-10 16:01 ` Timur Tabi
2009-02-10 16:10 ` Jean Delvare
2009-02-10 16:21 ` Timur Tabi
2009-02-10 16:28 ` Wolfram Sang
2009-02-11 0:16 ` Ben Dooks
2009-02-10 15:11 ` Wolfram Sang
2009-02-11 0:17 ` Ben Dooks
2009-02-19 16:41 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090210165554.0da8bf7c@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=ben-linux@fluff.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).