linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Jean-Michel Hautbois <jhautbois@gmail.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [MPC8272ADS]Problem adding flash partitions inside the device tree
Date: Fri, 13 Feb 2009 00:30:37 +1100	[thread overview]
Message-ID: <20090212133037.GA3651@yookeroo.seuss> (raw)
In-Reply-To: <8cad0aa0902120310g44a3bf3cla4ffa94ea9bf5dc6@mail.gmail.com>

On Thu, Feb 12, 2009 at 12:10:58PM +0100, Jean-Michel Hautbois wrote:
> 2009/2/12 Pieter <phenning@vastech.co.za>
> 
> > Jean-Michel Hautbois wrote:
> > > Warning (reg_format): "reg" property in
> > > /localbus@f0010100/flash@0,0/partition@ff800000 has invalid length (8
> > > JM
> > You are missing some definitions, The #address-cells and #size-cells = <1>;
> > tis is a snippet of teh dts i defined for my board.
> >
> >        flash@0,0 {
> >            #address-cells = <1>;
> >            #size-cells = <1>;
> >            compatible = "cfi-flash";
> >            reg = <0x0 0x0 0x08000000>;
> >             bank-width = <4>;
> >            device-width = <1>;
> >
> >             /* set flash partition to correspond tu mtd parts in
> > u-boot*/
> >            /*     0xf8000000 */
> >            partition@0x0 {
> >                label = "factory-image";
> >                reg = <0x00000000 0x01000000>;
> >            };
> >            /*     0xf9000000 */
> >            partition@0x01000000 {
> >                label = "app-image-1";
> >                reg = <0x01000000 0x01000000>;
> >            };
> > cheers pieter
> >
> 
> Hi do have these definitions, at a higher level:

The address-cells and size-cells definitions are not inherited.  They
cover only the immediate children of the node where they appear.
Otherwise the default values apply (address-cells == 2, size-cells ==
1), which are not right for your case.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2009-02-12 13:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12  9:23 [MPC8272ADS]Problem adding flash partitions inside the device tree Jean-Michel Hautbois
2009-02-12 11:05 ` Pieter
2009-02-12 11:10   ` Jean-Michel Hautbois
2009-02-12 13:30     ` David Gibson [this message]
2009-02-12 13:36       ` Jean-Michel Hautbois
2009-02-12 14:08         ` Pieter
2009-02-12 14:26           ` Jean-Michel Hautbois
2009-02-12 22:24             ` Scott Wood
2009-02-13  9:25               ` Jean-Michel Hautbois
2009-02-13 16:53                 ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090212133037.GA3651@yookeroo.seuss \
    --to=david@gibson.dropbear.id.au \
    --cc=jhautbois@gmail.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).