From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
mingo@redhat.com, hpa@zytor.com,
linux-pci@atrey.karlin.mff.cuni.cz, tglx@linutronix.de
Subject: Re: [PATCH] pci/msi: Use #ifdefs instead of weak functions
Date: Fri, 13 Feb 2009 13:13:47 -0800 [thread overview]
Message-ID: <200902131313.48615.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <d1c931db79adf22f3506aa0343aec5361600b37e.1232325038.git.michael@ellerman.id.au>
On Sunday, January 18, 2009 4:31 pm Michael Ellerman wrote:
> Weak functions aren't all they're cracked up to be. They lead to
> incorrect binaries with some toolchains, they require us to have empty
> functions we otherwise wouldn't, and the unused code is not elided
> (as of gcc 4.3.2 anyway).
>
> So replace the weak MSI arch hooks with the #define foo foo idiom. We no
> longer need empty versions of arch_setup/teardown_msi_irq().
>
> This is less source (by 1 line!), and results in smaller binaries too:
>
> text data bss dec hex filename
> 9354300 1693916 678424 11726640 b2ef30 build/powerpc/vmlinux-before
> 9354052 1693852 678424 11726328 b2edf8 build/powerpc/vmlinux-after
>
> Also smaller on x86_64 and arm (iop13xx).
>
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Applied to my linux-next branch, thanks Michael.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2009-02-13 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 0:31 [PATCH] pci/msi: Use #ifdefs instead of weak functions Michael Ellerman
2009-02-13 21:13 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902131313.48615.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).