linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Pierre Ossman <drzeus-sdhci@drzeus.cx>
Cc: Ben Dooks <ben-linux@fluff.org>, Arnd Bergmann <arnd@arndb.de>,
	Liu Dave <DaveLiu@freescale.com>,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	sdhci-devel@list.drzeus.cx
Subject: [PATCH 09/13] sdhci: Add set_clock callback and a quirk for nonstandard clocks
Date: Fri, 13 Feb 2009 17:47:33 +0300	[thread overview]
Message-ID: <20090213144733.GI23889@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090213144630.GA13436@oksana.dev.rtsoft.ru>

FSL eSDHC hosts have incompatible register map to manage the SDCLK.
This patch adds set_clock callback so that drivers could overwrite
set_clock behaviour.

Similar patch[1] was posted by Ben Dooks, though in Ben's version the
callback is named change_clock, plus the patch has some unrelated bits
that makes the patch difficult to reuse.

[1] http://lkml.org/lkml/2008/12/2/160

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 drivers/mmc/host/sdhci.c |    6 ++++++
 drivers/mmc/host/sdhci.h |    4 ++++
 2 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 96a0482..f63db25 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1013,6 +1013,12 @@ static void sdhci_set_clock(struct sdhci_host *host, unsigned int clock)
 	if (clock == host->clock)
 		return;
 
+	if (host->ops->set_clock) {
+		host->ops->set_clock(host, clock);
+		if (host->quirks & SDHCI_QUIRK_NONSTANDARD_CLOCK)
+			return;
+	}
+
 	sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL);
 
 	if (clock == 0)
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index ef70900..63b436a 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -225,6 +225,8 @@ struct sdhci_host {
 #define SDHCI_QUIRK_INVERTED_WRITE_PROTECT		(1<<17)
 /* Controller has all registers of 32 bit width */
 #define SDHCI_QUIRK_32BIT_REGISTERS			(1<<18)
+/* Controller has nonstandard clock management */
+#define SDHCI_QUIRK_NONSTANDARD_CLOCK			(1<<19)
 
 	int			irq;		/* Device IRQ */
 	void __iomem *		ioaddr;		/* Mapped address */
@@ -288,6 +290,8 @@ struct sdhci_ops {
 	void		(*writew)(struct sdhci_host *host, u16 val, int reg);
 	void		(*writeb)(struct sdhci_host *host, u8 val, int reg);
 
+	void	(*set_clock)(struct sdhci_host *host, unsigned int clock);
+
 	int		(*enable_dma)(struct sdhci_host *host);
 	unsigned int	(*get_max_clock)(struct sdhci_host *host);
 	unsigned int	(*get_timeout_clock)(struct sdhci_host *host);
-- 
1.5.6.5

  parent reply	other threads:[~2009-02-13 14:47 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13 14:46 [PATCH RFC 0/13] FSL eSDHC support Anton Vorontsov
2009-02-13 14:47 ` [PATCH 01/13] sdhci: Add quirk for controllers with no end-of-busy IRQ Anton Vorontsov
2009-02-13 14:47 ` [PATCH 02/13] sdhci: Add support for bus-specific IO memory accessors Anton Vorontsov
2009-02-13 14:47 ` [PATCH 03/13] sdhci: Split card-detection IRQs management from sdhci_init() Anton Vorontsov
2009-02-21 15:58   ` Pierre Ossman
2009-02-13 14:47 ` [PATCH 04/13] sdhci: Enable only relevant (DMA/PIO) interrupts during transfers Anton Vorontsov
2009-02-13 14:47 ` [PATCH 05/13] sdhci: Add support for card-detection polling Anton Vorontsov
2009-02-21 15:58   ` Pierre Ossman
2009-03-04 17:49     ` Anton Vorontsov
2009-03-08 14:11       ` Pierre Ossman
2009-03-16 21:05         ` Anton Vorontsov
2009-02-13 14:47 ` [PATCH 06/13] sdhci: Add support for hosts reporting inverted write-protect state Anton Vorontsov
2009-02-13 14:47 ` [PATCH 07/13] sdhci: Add support for hosts with strict 32 bit addressing Anton Vorontsov
2009-02-21 15:58   ` Pierre Ossman
2009-03-04 17:48     ` Anton Vorontsov
2009-03-08 14:17       ` Pierre Ossman
2009-02-13 14:47 ` [PATCH 08/13] sdhci: Add get_{max,timeout}_clock callbacks Anton Vorontsov
2009-02-13 14:47 ` Anton Vorontsov [this message]
2009-02-13 14:47 ` [PATCH 10/13] sdhci: Add quirk for controllers that need small delays for PIO Anton Vorontsov
2009-02-13 14:47 ` [PATCH 11/13] sdhci: Add quirk for controllers that need IRQ re-init after reset Anton Vorontsov
2009-02-13 15:47   ` Laurent Pinchart
2009-02-13 17:30     ` Anton Vorontsov
2009-02-13 14:47 ` [PATCH 12/13] sdhci: Add quirk for controllers with max. block size up to 4096 bytes Anton Vorontsov
2009-02-21 15:58   ` Pierre Ossman
2009-03-04 17:47     ` Anton Vorontsov
2009-03-08 14:21       ` Pierre Ossman
2009-02-13 14:47 ` [PATCH 13/13] mmc: Add OpenFirmware bindings for SDHCI driver Anton Vorontsov
2009-02-17 16:31 ` [PATCH RFC 0/13] FSL eSDHC support Ben Dooks
  -- strict thread matches above, loose matches on Subject: below --
2009-02-20 17:32 [PATCH " Anton Vorontsov
2009-02-20 17:33 ` [PATCH 09/13] sdhci: Add set_clock callback and a quirk for nonstandard clocks Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090213144733.GI23889@oksana.dev.rtsoft.ru \
    --to=avorontsov@ru.mvista.com \
    --cc=DaveLiu@freescale.com \
    --cc=arnd@arndb.de \
    --cc=ben-linux@fluff.org \
    --cc=drzeus-sdhci@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sdhci-devel@list.drzeus.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).