From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: linuxppc-dev@ozlabs.org, henk.stegeman@gmail.com,
bridge@osdl.org, netdev@vger.kernel.org
Subject: Re: net_device_ops support in bridging and fec_mpc52xx.c
Date: Wed, 18 Feb 2009 14:31:16 -0800 [thread overview]
Message-ID: <20090218143116.69948299@extreme> (raw)
In-Reply-To: <20090218.134852.118040610.davem@davemloft.net>
On Wed, 18 Feb 2009 13:48:52 -0800 (PST)
David Miller <davem@davemloft.net> wrote:
> From: Henk Stegeman <henk.stegeman@gmail.com>
> Date: Wed, 18 Feb 2009 11:41:14 +0100
>
> Please CC: netdev, now added, on all networking reports and patches.
>
> Thank you.
>
> > I discovered the hard way that because linux bridging uses
> > net_device_ops, bridging only works with network drivers that publish
> > their device operations trough net_device_ops.
> >
> > In my case running:
> >
> > brctl addif br0 eth0 (where eth0 fec_mpc52xx.c did not yet support
> > net_device_ops) gave me a:
> >
> > Unable to handle kernel paging request...
> >
> > After changing fec_mpc52xx.c to support net_device_ops the problem was fixed.
> >
> > If possible some kind of detection in the bridging software is i think
> > mostly appreciated for early detection of this problem, as it is
> > pretty hard to relate the error message to a not updated driver.
> >
> > cheers,
> >
> > Henk
The normal register_netdevice stuff take care of setting up net_device_ops
for old style drivers. Was there something different about how this
device was being setup?
next prev parent reply other threads:[~2009-02-18 22:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 10:41 net_device_ops support in bridging and fec_mpc52xx.c Henk Stegeman
2009-02-18 21:48 ` David Miller
2009-02-18 22:31 ` Stephen Hemminger [this message]
2009-02-19 9:45 ` Henk Stegeman
2009-03-10 17:13 ` Grant Likely
2009-03-10 17:19 ` David Miller
2009-03-10 17:36 ` Grant Likely
2009-03-21 22:00 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090218143116.69948299@extreme \
--to=shemminger@vyatta.com \
--cc=bridge@osdl.org \
--cc=davem@davemloft.net \
--cc=henk.stegeman@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).