From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Liu Dave <DaveLiu@freescale.com>,
Andy Fleming <afleming@freescale.com>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/83xx: Do not configure or probe disabled FSL DR USB controllers
Date: Thu, 19 Feb 2009 20:29:02 +0300 [thread overview]
Message-ID: <20090219172902.GA11227@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <8EC0BAAB-7261-406F-BA42-BE6D9EC55AAB@kernel.crashing.org>
On Thu, Feb 19, 2009 at 10:19:05AM -0600, Kumar Gala wrote:
>
> On Feb 19, 2009, at 10:02 AM, Anton Vorontsov wrote:
>
>> On MPC837X CPUs Dual-Role USB isn't always available (for example DR
>> USB pins can be muxed away to eSDHC).
>>
>> U-Boot adds status = "disabled" property into the DR USB nodes to
>> indicate that we must not try to configure or probe Dual-Role USB,
>> otherwise we'll break eSDHC support on targets with MPC837X CPUs.
>>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>> ---
>> arch/powerpc/platforms/83xx/usb.c | 3 ++-
>> arch/powerpc/sysdev/fsl_soc.c | 4 ++++
>> 2 files changed, 6 insertions(+), 1 deletions(-)
>
> Mind looking at possibly killing the fsl_soc.c usb code and making the
> usb a real of-platform driver?
Sure, but it's a bit complicated because of OTG support (which
doesn't currently work, btw).
Just need to think about whether we want to leave UDC and HOST
drivers as pure platform drivers, and implement an of platform
driver as a proxy for Host/UDC/OTG...
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-02-19 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 16:02 [PATCH] powerpc/83xx: Do not configure or probe disabled FSL DR USB controllers Anton Vorontsov
2009-02-19 16:19 ` Kumar Gala
2009-02-19 17:29 ` Anton Vorontsov [this message]
2009-02-19 16:43 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090219172902.GA11227@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=DaveLiu@freescale.com \
--cc=afleming@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).