linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus@drzeus.cx>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Ben Dooks <ben-linux@fluff.org>, Arnd Bergmann <arnd@arndb.de>,
	Liu Dave <DaveLiu@freescale.com>,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	sdhci-devel@list.drzeus.cx,
	Pierre Ossman <drzeus-sdhci@drzeus.cx>
Subject: Re: [PATCH 07/13] sdhci: Add support for hosts with strict 32 bit addressing
Date: Sat, 21 Feb 2009 16:58:33 +0100	[thread overview]
Message-ID: <20090221165833.6dec220a@mjolnir.ossman.eu> (raw)
In-Reply-To: <20090213144722.GG23889@oksana.dev.rtsoft.ru>

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

On Fri, 13 Feb 2009 17:47:22 +0300
Anton Vorontsov <avorontsov@ru.mvista.com> wrote:

> SDHCI driver must take special care when working with "triggering"
> registers on hosts with strict 32 bit addressing.
> 
> In FSL eSDHC hosts all registers are 32 bit width, writing to the
> first half of any register will cause [undefined?] write the second
> half of the register. That is, 16 bit write to the TRANSFER_MODE
> register, makes hardware see a bogus write to the COMMAND register
> (these two registers are adjacent).
> 
> This patch adds SDHCI_QUIRK_32BIT_REGISTERS quirk. When specified,
> the sdhci driver will try to "pack" all dangerous writes into single
> 32 bit write transaction.
> 
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---

What about the other places where we have 16 and 8 bit registers?

-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2009-02-21 15:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13 14:46 [PATCH RFC 0/13] FSL eSDHC support Anton Vorontsov
2009-02-13 14:47 ` [PATCH 01/13] sdhci: Add quirk for controllers with no end-of-busy IRQ Anton Vorontsov
2009-02-13 14:47 ` [PATCH 02/13] sdhci: Add support for bus-specific IO memory accessors Anton Vorontsov
2009-02-13 14:47 ` [PATCH 03/13] sdhci: Split card-detection IRQs management from sdhci_init() Anton Vorontsov
2009-02-21 15:58   ` Pierre Ossman
2009-02-13 14:47 ` [PATCH 04/13] sdhci: Enable only relevant (DMA/PIO) interrupts during transfers Anton Vorontsov
2009-02-13 14:47 ` [PATCH 05/13] sdhci: Add support for card-detection polling Anton Vorontsov
2009-02-21 15:58   ` Pierre Ossman
2009-03-04 17:49     ` Anton Vorontsov
2009-03-08 14:11       ` Pierre Ossman
2009-03-16 21:05         ` Anton Vorontsov
2009-02-13 14:47 ` [PATCH 06/13] sdhci: Add support for hosts reporting inverted write-protect state Anton Vorontsov
2009-02-13 14:47 ` [PATCH 07/13] sdhci: Add support for hosts with strict 32 bit addressing Anton Vorontsov
2009-02-21 15:58   ` Pierre Ossman [this message]
2009-03-04 17:48     ` Anton Vorontsov
2009-03-08 14:17       ` Pierre Ossman
2009-02-13 14:47 ` [PATCH 08/13] sdhci: Add get_{max,timeout}_clock callbacks Anton Vorontsov
2009-02-13 14:47 ` [PATCH 09/13] sdhci: Add set_clock callback and a quirk for nonstandard clocks Anton Vorontsov
2009-02-13 14:47 ` [PATCH 10/13] sdhci: Add quirk for controllers that need small delays for PIO Anton Vorontsov
2009-02-13 14:47 ` [PATCH 11/13] sdhci: Add quirk for controllers that need IRQ re-init after reset Anton Vorontsov
2009-02-13 15:47   ` Laurent Pinchart
2009-02-13 17:30     ` Anton Vorontsov
2009-02-13 14:47 ` [PATCH 12/13] sdhci: Add quirk for controllers with max. block size up to 4096 bytes Anton Vorontsov
2009-02-21 15:58   ` Pierre Ossman
2009-03-04 17:47     ` Anton Vorontsov
2009-03-08 14:21       ` Pierre Ossman
2009-02-13 14:47 ` [PATCH 13/13] mmc: Add OpenFirmware bindings for SDHCI driver Anton Vorontsov
2009-02-17 16:31 ` [PATCH RFC 0/13] FSL eSDHC support Ben Dooks
  -- strict thread matches above, loose matches on Subject: below --
2009-02-20 17:32 [PATCH " Anton Vorontsov
2009-02-20 17:33 ` [PATCH 07/13] sdhci: Add support for hosts with strict 32 bit addressing Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090221165833.6dec220a@mjolnir.ossman.eu \
    --to=drzeus@drzeus.cx \
    --cc=DaveLiu@freescale.com \
    --cc=arnd@arndb.de \
    --cc=avorontsov@ru.mvista.com \
    --cc=ben-linux@fluff.org \
    --cc=drzeus-sdhci@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sdhci-devel@list.drzeus.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).