From: David Miller <davem@davemloft.net>
To: rini@arvoo.nl
Cc: Linuxppc-dev@ozlabs.org, afleming@freescale.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] gianfar : Do right check on num_txbdfree
Date: Thu, 26 Feb 2009 02:03:18 -0800 (PST) [thread overview]
Message-ID: <20090226.020318.50178027.davem@davemloft.net> (raw)
In-Reply-To: <49A6595A.9000405@arvoo.nl>
From: Rini van Zetten <rini@arvoo.nl>
Date: Thu, 26 Feb 2009 09:56:58 +0100
> This patch fixes a wrong check on num_txbdfree. It could lead to
> num_txbdfree become nagative. Result was that the gianfar stops
> sending data.
>
> Signed-off-by: Rini van Zetten <rini at arvoo dot nl
Please use rini@arvoo.nl in your signoffs, you cannot
hide on the inna-net.
> - if (nr_frags > priv->num_txbdfree) {
> + if ( (nr_frags+1) > priv->num_txbdfree) {
Please don't put a space between the parens there "( (", like
that.
next prev parent reply other threads:[~2009-02-26 10:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 8:56 [PATCH net] gianfar : Do right check on num_txbdfree Rini van Zetten
2009-02-26 10:03 ` David Miller [this message]
2009-02-26 10:25 ` [PATCH v2 " Rini van Zetten
2009-02-26 16:03 ` Geert Uytterhoeven
2009-02-26 22:07 ` Andy Fleming
2009-02-27 11:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090226.020318.50178027.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Linuxppc-dev@ozlabs.org \
--cc=afleming@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=rini@arvoo.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).