From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 27 Feb 2009 03:18:57 -0800 (PST) Message-Id: <20090227.031857.240013447.davem@davemloft.net> To: afleming@gmail.com Subject: Re: [PATCH v2 net] gianfar : Do right check on num_txbdfree From: David Miller In-Reply-To: <2acbd3e40902261407w7e92dbe0u4dd008b3e6b239a2@mail.gmail.com> References: <20090226.020318.50178027.davem@davemloft.net> <49A66E2D.3060204@arvoo.nl> <2acbd3e40902261407w7e92dbe0u4dd008b3e6b239a2@mail.gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Cc: Linuxppc-dev@ozlabs.org, rini@arvoo.nl, afleming@freescale.com, netdev@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andy Fleming Date: Thu, 26 Feb 2009 16:07:16 -0600 > On Thu, Feb 26, 2009 at 4:25 AM, Rini van Zetten wrote: > > This patch fixes a wrong check on num_txbdfree. It could lead to > > num_txbdfree become nagative. > > Result was that the gianfar stops sending data. > > > > Changes from first version : > > - removed a space between parens (David Millers comment) > > - full email address in signed off line > > > > > > Signed-off-by: Rini van Zetten > > Good catch. Does this solve the bug you reported earlier? > > Acked-by: Andy Fleming Applied, thanks.