From: Grant Likely <grant.likely@secretlab.ca>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH] powerpc/5200: remove sysfs debug file from GPT driver
Date: Fri, 06 Mar 2009 13:30:45 -0700 [thread overview]
Message-ID: <20090306203044.22371.75222.stgit@localhost.localdomain> (raw)
From: Grant Likely <grant.likely@secretlab.ca>
Remove poorly designed debug sysfs attribute entry from the GPT driver.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 39 -----------------------------
1 files changed, 0 insertions(+), 39 deletions(-)
diff --git a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c b/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
index cb038dc..bfbcd41 100644
--- a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
+++ b/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
@@ -335,44 +335,6 @@ static void
mpc52xx_gpt_gpio_setup(struct mpc52xx_gpt_priv *p, struct device_node *np) { }
#endif /* defined(CONFIG_GPIOLIB) */
-/***********************************************************************
- * SYSFS attributes
- */
-#if defined(CONFIG_SYSFS)
-static ssize_t mpc52xx_gpt_show_regs(struct device *dev,
- struct device_attribute *attr, char *buf)
-{
- struct mpc52xx_gpt_priv *gpt = dev_get_drvdata(dev);
- int i, len = 0;
- u32 __iomem *regs = (void __iomem *) gpt->regs;
-
- for (i = 0; i < 4; i++)
- len += sprintf(buf + len, "%.8x ", in_be32(regs + i));
- len += sprintf(buf + len, "\n");
-
- return len;
-}
-
-static struct device_attribute mpc52xx_gpt_attrib[] = {
- __ATTR(regs, S_IRUGO | S_IWUSR, mpc52xx_gpt_show_regs, NULL),
-};
-
-static void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *gpt)
-{
- int i, err = 0;
-
- for (i = 0; i < ARRAY_SIZE(mpc52xx_gpt_attrib); i++) {
- err = device_create_file(gpt->dev, &mpc52xx_gpt_attrib[i]);
- if (err)
- dev_err(gpt->dev, "error creating attribute %i\n", i);
- }
-
-}
-
-#else /* defined(CONFIG_SYSFS) */
-static void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *) { return 0; }
-#endif /* defined(CONFIG_SYSFS) */
-
/* ---------------------------------------------------------------------
* of_platform bus binding code
*/
@@ -395,7 +357,6 @@ static int __devinit mpc52xx_gpt_probe(struct of_device *ofdev,
dev_set_drvdata(&ofdev->dev, gpt);
- mpc52xx_gpt_create_attribs(gpt);
mpc52xx_gpt_gpio_setup(gpt, ofdev->node);
mpc52xx_gpt_irq_setup(gpt, ofdev->node);
next reply other threads:[~2009-03-06 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 20:30 Grant Likely [this message]
2009-03-06 20:31 ` [PATCH] powerpc/5200: remove sysfs debug file from GPT driver Grant Likely
2009-03-07 10:13 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090306203044.22371.75222.stgit@localhost.localdomain \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).