linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/bootwrapper: add fixed-head.o to simpleimage wrappers
@ 2009-03-09 15:23 Grant Likely
  2009-03-11  5:49 ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 2+ messages in thread
From: Grant Likely @ 2009-03-09 15:23 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: eddie

From: Grant Likely <grant.likely@secretlab.ca>

fixed-head.o must be linked into the bootwrapper for raw-binary images to
work.  This patch adds it into the bootwrapper.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Reported-by: Eddie Dawydiuk <eddie@embeddedarm.com>
---

I pulled this chunk out of Eddie's bigger patch and also modified the other
case where it applies.  This is a definite bug on the simpleimage generation.
Once I get an ack, I'll add it to my -next tree and ask Ben to pull.

Cheers,
g.

 arch/powerpc/boot/wrapper |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper
index 965c237..c5bd9cf 100755
--- a/arch/powerpc/boot/wrapper
+++ b/arch/powerpc/boot/wrapper
@@ -211,11 +211,11 @@ simpleboot-virtex405-*)
     binary=y
     ;;
 simpleboot-virtex440-*)
-    platformo="$object/simpleboot.o $object/virtex.o"
+    platformo="$object/fixed-head.o $object/simpleboot.o $object/virtex.o"
     binary=y
     ;;
 simpleboot-*)
-    platformo="$object/simpleboot.o"
+    platformo="$object/fixed-head.o $object/simpleboot.o"
     binary=y
     ;;
 asp834x-redboot)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc/bootwrapper: add fixed-head.o to simpleimage wrappers
  2009-03-09 15:23 [PATCH] powerpc/bootwrapper: add fixed-head.o to simpleimage wrappers Grant Likely
@ 2009-03-11  5:49 ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2009-03-11  5:49 UTC (permalink / raw)
  To: Grant Likely; +Cc: linuxppc-dev, eddie

On Mon, 2009-03-09 at 09:23 -0600, Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
> 
> fixed-head.o must be linked into the bootwrapper for raw-binary images to
> work.  This patch adds it into the bootwrapper.
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> Reported-by: Eddie Dawydiuk <eddie@embeddedarm.com>
> ---

Ack :-)

> I pulled this chunk out of Eddie's bigger patch and also modified the other
> case where it applies.  This is a definite bug on the simpleimage generation.
> Once I get an ack, I'll add it to my -next tree and ask Ben to pull.
> 
> Cheers,
> g.
> 
>  arch/powerpc/boot/wrapper |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper
> index 965c237..c5bd9cf 100755
> --- a/arch/powerpc/boot/wrapper
> +++ b/arch/powerpc/boot/wrapper
> @@ -211,11 +211,11 @@ simpleboot-virtex405-*)
>      binary=y
>      ;;
>  simpleboot-virtex440-*)
> -    platformo="$object/simpleboot.o $object/virtex.o"
> +    platformo="$object/fixed-head.o $object/simpleboot.o $object/virtex.o"
>      binary=y
>      ;;
>  simpleboot-*)
> -    platformo="$object/simpleboot.o"
> +    platformo="$object/fixed-head.o $object/simpleboot.o"
>      binary=y
>      ;;
>  asp834x-redboot)
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-03-11  5:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-09 15:23 [PATCH] powerpc/bootwrapper: add fixed-head.o to simpleimage wrappers Grant Likely
2009-03-11  5:49 ` Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).