From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Mikhail Zolotaryov <lebon@lebon.org.ua>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc 4xx: DDR0_14[REDUC] decoded incorrectly
Date: Mon, 9 Mar 2009 13:12:43 -0400 [thread overview]
Message-ID: <20090309171243.GA26415@zod.rchland.ibm.com> (raw)
In-Reply-To: <49B54210.5040709@lebon.org.ua>
On Mon, Mar 09, 2009 at 06:21:36PM +0200, Mikhail Zolotaryov wrote:
> Hi,
>
> according to the PPC440EPx Embedded Processor User Manual (rev 1.14)
> DDR0_14[REDUC] bit has the following meaning:
>
> REDUC - Enable the half data path feature of the controller
> 0 = Standard operation using full 64/72-bit memory bus
> 1 = Memory data path width is 32/40 bits
>
> However, "1" is decoded as 64 bit (8 byte), "0" - as 32 bit (4 byte) bus
> by the kernel code. My understanding is this is not correct - patch
> attached.
You are missing the Signed-off-by tag that is needed.
Aside from that, I'm curious if you found this just through inspection, or
if you actually had a problem because of it. Your fix seems correct, yet
I've had no problems with my boards at all.
josh
next prev parent reply other threads:[~2009-03-09 17:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 16:21 [PATCH] powerpc 4xx: DDR0_14[REDUC] decoded incorrectly Mikhail Zolotaryov
2009-03-09 17:12 ` Josh Boyer [this message]
2009-03-09 21:17 ` Mikhail Zolotaryov
2009-03-10 19:50 ` [PATCH] PowerPC 440EPx/GRx fix memory size calculation Valentine Barshak
2009-03-10 20:57 ` Mikhail Zolotaryov
2009-03-11 1:40 ` Valentine
2009-03-11 2:26 ` Benjamin Herrenschmidt
2009-03-11 8:24 ` Mikhail Zolotaryov
2009-03-11 8:29 ` Mikhail Zolotaryov
2009-03-11 10:37 ` Josh Boyer
2009-03-11 19:06 ` Valentine Barshak
2009-03-11 21:57 ` Josh Boyer
2009-03-11 22:08 ` Valentine
2009-03-11 23:07 ` Josh Boyer
2009-03-12 6:02 ` Stefan Roese
2009-03-12 7:32 ` Benjamin Herrenschmidt
2009-03-12 8:05 ` Stefan Roese
2009-03-12 8:12 ` Benjamin Herrenschmidt
2009-03-12 8:24 ` Stefan Roese
2009-03-12 8:45 ` Mikhail Zolotaryov
2009-03-12 10:45 ` Josh Boyer
2009-03-12 11:02 ` Stefan Roese
2009-03-13 23:01 ` Feng Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090309171243.GA26415@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=lebon@lebon.org.ua \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).