* [patch 1/1] powerpc: remove setup_irq(NULL action) in ksi8560
@ 2009-03-10 18:43 Thomas Gleixner
2009-03-10 18:53 ` Kumar Gala
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Gleixner @ 2009-03-10 18:43 UTC (permalink / raw)
To: Linux PPC Development
setup_irq(0, NULL) is broken as setup_irq() dereferences action
unconditionally.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
CC: Kumar Gala <galak@kernel.crashing.org>
CC: Linux PPC Development <linuxppc-dev@ozlabs.org>
---
arch/powerpc/platforms/85xx/ksi8560.c | 2 --
1 file changed, 2 deletions(-)
Index: linux-2.6-tip/arch/powerpc/platforms/85xx/ksi8560.c
===================================================================
--- linux-2.6-tip.orig/arch/powerpc/platforms/85xx/ksi8560.c
+++ linux-2.6-tip/arch/powerpc/platforms/85xx/ksi8560.c
@@ -106,8 +106,6 @@ static void __init ksi8560_pic_init(void
cpm2_pic_init(np);
of_node_put(np);
set_irq_chained_handler(irq, cpm2_cascade);
-
- setup_irq(0, NULL);
#endif
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 1/1] powerpc: remove setup_irq(NULL action) in ksi8560
2009-03-10 18:43 [patch 1/1] powerpc: remove setup_irq(NULL action) in ksi8560 Thomas Gleixner
@ 2009-03-10 18:53 ` Kumar Gala
0 siblings, 0 replies; 2+ messages in thread
From: Kumar Gala @ 2009-03-10 18:53 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Linux PPC Development
On Mar 10, 2009, at 1:43 PM, Thomas Gleixner wrote:
> setup_irq(0, NULL) is broken as setup_irq() dereferences action
> unconditionally.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> CC: Kumar Gala <galak@kernel.crashing.org>
> CC: Linux PPC Development <linuxppc-dev@ozlabs.org>
> ---
> arch/powerpc/platforms/85xx/ksi8560.c | 2 --
> 1 file changed, 2 deletions(-)
applied to next
- k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-10 18:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-10 18:43 [patch 1/1] powerpc: remove setup_irq(NULL action) in ksi8560 Thomas Gleixner
2009-03-10 18:53 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox