From: Stefan Roese <sr@denx.de>
To: linuxppc-dev@ozlabs.org
Cc: lebon@lebon.org.ua
Subject: Re: [PATCH] PowerPC 440EPx/GRx fix memory size calculation
Date: Thu, 12 Mar 2009 07:02:03 +0100 [thread overview]
Message-ID: <200903120702.03286.sr@denx.de> (raw)
In-Reply-To: <49B80BA3.1090301@ru.mvista.com>
On Wednesday 11 March 2009, Valentine Barshak wrote:
> I've been looking at the docs once again and actually I couldn't find an
> explanation there. And I don't have that e-mail from AMCC support
> that I got a while back regarding the issue anymore.
> There might have been some misunderstanding.
> The docs (PPC440EPX UM 19.2 Device Address Mapping) say that the chip
> select field width is always fixed at one bit, but this doesn't actually
> mean that there's always one chip select used.
> The patch works fine on Sequoia and another Sequoia-like board with 1GB
> RAM installed, but it might not work with 2GB RAM. I've tried to play
> with DDR0_10 settings and Sequoia works fine regardless of what's
> actually written to DDR0_10.
> So, probably the best way would be to fix that in u-boot
> amcc/sequoia/sdram.c by doing mtsdram(DDR0_10, 0x00000100); instead of
> mtsdram(DDR0_10, 0x00000300);
> Sorry, for confusion, but after reviewing the docs, I think that
> only REDUC interpretation has to be fixed. The chips select part should
> be fixed in u-boot sdram code for Sequoia as was originally proposed by
> Mikhail.
>
> Stefan, could you please take a look?
I'll apply the U-Boot patch today. But as Josh pointed out, we should try to
find a way for the bootwrapper to work in all cases.
Best regards,
Stefan
next prev parent reply other threads:[~2009-03-12 6:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 16:21 [PATCH] powerpc 4xx: DDR0_14[REDUC] decoded incorrectly Mikhail Zolotaryov
2009-03-09 17:12 ` Josh Boyer
2009-03-09 21:17 ` Mikhail Zolotaryov
2009-03-10 19:50 ` [PATCH] PowerPC 440EPx/GRx fix memory size calculation Valentine Barshak
2009-03-10 20:57 ` Mikhail Zolotaryov
2009-03-11 1:40 ` Valentine
2009-03-11 2:26 ` Benjamin Herrenschmidt
2009-03-11 8:24 ` Mikhail Zolotaryov
2009-03-11 8:29 ` Mikhail Zolotaryov
2009-03-11 10:37 ` Josh Boyer
2009-03-11 19:06 ` Valentine Barshak
2009-03-11 21:57 ` Josh Boyer
2009-03-11 22:08 ` Valentine
2009-03-11 23:07 ` Josh Boyer
2009-03-12 6:02 ` Stefan Roese [this message]
2009-03-12 7:32 ` Benjamin Herrenschmidt
2009-03-12 8:05 ` Stefan Roese
2009-03-12 8:12 ` Benjamin Herrenschmidt
2009-03-12 8:24 ` Stefan Roese
2009-03-12 8:45 ` Mikhail Zolotaryov
2009-03-12 10:45 ` Josh Boyer
2009-03-12 11:02 ` Stefan Roese
2009-03-13 23:01 ` Feng Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903120702.03286.sr@denx.de \
--to=sr@denx.de \
--cc=lebon@lebon.org.ua \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).