[PATCH] powerpc: Remove extra semicolon in fsl_soc.c

[PATCH] powerpc: Remove extra semicolon in fsl_soc.c

[Johns Daniel]

A semicolon at the end of the macro means that the for loop has an
empty body, and so TSEC/MDIO will not work with older device trees.

This fix only applies to 2.6.28; apparently, this code is gone for
2.6.29, according to Grant Likely!

Signed-off-by: Johns Daniel <johns.daniel@gmail.com>
---
--- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig   2009-02-20
16:41:27.000000000 -0600
+++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c        2009-03-10
15:56:47.000000000 -0500
@@ -257,7 +257,7 @@
                gfar_mdio_of_init_one(np);

        /* try the deprecated version */
-       for_each_compatible_node(np, "mdio", "gianfar");
+       for_each_compatible_node(np, "mdio", "gianfar")
                gfar_mdio_of_init_one(np);

        return 0;
---

Re: [PATCH] powerpc: Remove extra semicolon in fsl_soc.c

[Grant Likely]

On Wed, Mar 11, 2009 at 9:50 AM, Johns Daniel <johns.daniel@gmail.com> wrot=
e:
> A semicolon at the end of the macro means that the for loop has an
> empty body, and so TSEC/MDIO will not work with older device trees.
>
> This fix only applies to 2.6.28; apparently, this code is gone for
> 2.6.29, according to Grant Likely!
>
> Signed-off-by: Johns Daniel <johns.daniel@gmail.com>

Acked-by: Grant Likely <grant.likely@secretlab.ca>

Greg:  Andy Flemming should probably confirm this, but I think this
one should be backported to the stable series.

g.

> ---
> --- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig =A0 2009-02-20
> 16:41:27.000000000 -0600
> +++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c =A0 =A0 =A0 =A02009-03-1=
0
> 15:56:47.000000000 -0500
> @@ -257,7 +257,7 @@
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0gfar_mdio_of_init_one(np);
>
> =A0 =A0 =A0 =A0/* try the deprecated version */
> - =A0 =A0 =A0 for_each_compatible_node(np, "mdio", "gianfar");
> + =A0 =A0 =A0 for_each_compatible_node(np, "mdio", "gianfar")
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0gfar_mdio_of_init_one(np);
>
> =A0 =A0 =A0 =A0return 0;
> ---
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>



--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: [stable] [PATCH] powerpc: Remove extra semicolon in fsl_soc.c

[Greg KH]

On Wed, Mar 11, 2009 at 10:03:22AM -0600, Grant Likely wrote:
> On Wed, Mar 11, 2009 at 9:50 AM, Johns Daniel <johns.daniel@gmail.com> wrote:
> > A semicolon at the end of the macro means that the for loop has an
> > empty body, and so TSEC/MDIO will not work with older device trees.
> >
> > This fix only applies to 2.6.28; apparently, this code is gone for
> > 2.6.29, according to Grant Likely!
> >
> > Signed-off-by: Johns Daniel <johns.daniel@gmail.com>
> 
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> 
> Greg:  Andy Flemming should probably confirm this, but I think this
> one should be backported to the stable series.

That's what he is asking for as he sent it to stable@kernel.org and
asked that it go into the 2.6.28 tree only :)

thanks,

greg k-h

Re: [PATCH] powerpc: Remove extra semicolon in fsl_soc.c

[Greg KH]

On Wed, Mar 11, 2009 at 10:03:22AM -0600, Grant Likely wrote:
> On Wed, Mar 11, 2009 at 9:50 AM, Johns Daniel <johns.daniel@gmail.com> wrote:
> > A semicolon at the end of the macro means that the for loop has an
> > empty body, and so TSEC/MDIO will not work with older device trees.
> >
> > This fix only applies to 2.6.28; apparently, this code is gone for
> > 2.6.29, according to Grant Likely!
> >
> > Signed-off-by: Johns Daniel <johns.daniel@gmail.com>
> 
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> 
> Greg:  Andy Flemming should probably confirm this, but I think this
> one should be backported to the stable series.

Hm, this patch is line-wrapped and tabs are stripped, so I can't apply
it :(

Anyone care to resend it?

thanks,

greg k-h

> > ---
> > --- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig   2009-02-20
> > 16:41:27.000000000 -0600
> > +++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c        2009-03-10
> > 15:56:47.000000000 -0500
> > @@ -257,7 +257,7 @@
> >                gfar_mdio_of_init_one(np);
> >
> >        /* try the deprecated version */
> > -       for_each_compatible_node(np, "mdio", "gianfar");
> > +       for_each_compatible_node(np, "mdio", "gianfar")
> >                gfar_mdio_of_init_one(np);
> >
> >        return 0;
> > ---
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@ozlabs.org
> > https://ozlabs.org/mailman/listinfo/linuxppc-dev
> >
> 
> 
> 
> -- 
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.