From: David Gibson <david@gibson.dropbear.id.au>
To: Martyn Welch <martyn.welch@gefanuc.com>
Cc: linuxppc-dev@ozlabs.org, wim@iguana.be
Subject: Re: [PATCH 1/2] powerpc/86xx: Board support for GE Fanuc's PPC9A
Date: Sat, 14 Mar 2009 13:16:42 +1100 [thread overview]
Message-ID: <20090314021642.GA7094@yookeroo.seuss> (raw)
In-Reply-To: <20090313155226.25810.79323.stgit@ubuntu8041.localdomain>
On Fri, Mar 13, 2009 at 03:52:26PM +0000, Martyn Welch wrote:
> Support for the PPC9A VME Single Board Computer from GE Fanuc (PowerPC
> MPC8641D).
>
> This is the basic board support for GE Fanuc's PPC9A, a 6U single board
> computer, based on Freescale's MPC8641D.
>
> Signed-off-by: Martyn Welch <martyn.welch@gefanuc.com>
[snip]
> + soc@fef00000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + #interrupt-cells = <2>;
> + device_type = "soc";
> + compatible = "simple-bus";
There should be more detail in the compatible field - list the
specific model of the SoC, before including "simple-bus". device_type
also doesn't really belong here, but it's possible you have to include
it for compatibility with older u-boot versions.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2009-03-14 2:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 15:52 [PATCH 0/2] powerpc/86xx: Board support for GE Fanuc PPC9A Martyn Welch
2009-03-13 15:52 ` [PATCH 1/2] powerpc/86xx: Board support for GE Fanuc's PPC9A Martyn Welch
2009-03-14 2:16 ` David Gibson [this message]
2009-03-13 15:52 ` [PATCH 2/2] powerpc/86xx: Default configuration " Martyn Welch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090314021642.GA7094@yookeroo.seuss \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=martyn.welch@gefanuc.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).