From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Pierre Ossman <drzeus-sdhci@drzeus.cx>
Cc: Ben Dooks <ben-linux@fluff.org>, Arnd Bergmann <arnd@arndb.de>,
Liu Dave <DaveLiu@freescale.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
sdhci-devel@list.drzeus.cx
Subject: [PATCH 10/11] sdhci: Add quirk for forcing maximum block size to 2048 bytes
Date: Tue, 17 Mar 2009 00:14:03 +0300 [thread overview]
Message-ID: <20090316211403.GJ9375@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090316211306.GA1736@oksana.dev.rtsoft.ru>
FSL eSDHC controllers can support maximum block size up to 4096 bytes,
the MBL (Maximum Block Length) field in the capabilities register
extended by one bit, and is set to 0x3.
But the SDHCI core doesn't support blocks of 4096 bytes, and thus
forces blksz to the lowest value -- 512 bytes. With this patch we can
pin up the blksz to the maximum supported block size, i.e. 2048 bytes.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
drivers/mmc/host/sdhci.c | 20 +++++++++++++-------
drivers/mmc/host/sdhci.h | 2 ++
2 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 3a72fe2..30d8e3d 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1777,13 +1777,19 @@ int sdhci_add_host(struct sdhci_host *host)
* Maximum block size. This varies from controller to controller and
* is specified in the capabilities register.
*/
- mmc->max_blk_size = (caps & SDHCI_MAX_BLOCK_MASK) >> SDHCI_MAX_BLOCK_SHIFT;
- if (mmc->max_blk_size >= 3) {
- printk(KERN_WARNING "%s: Invalid maximum block size, "
- "assuming 512 bytes\n", mmc_hostname(mmc));
- mmc->max_blk_size = 512;
- } else
- mmc->max_blk_size = 512 << mmc->max_blk_size;
+ if (host->quirks & SDHCI_QUIRK_FORCE_BLK_SZ_2048) {
+ mmc->max_blk_size = 2;
+ } else {
+ mmc->max_blk_size = (caps & SDHCI_MAX_BLOCK_MASK) >>
+ SDHCI_MAX_BLOCK_SHIFT;
+ if (mmc->max_blk_size >= 3) {
+ printk(KERN_WARNING "%s: Invalid maximum block size, "
+ "assuming 512 bytes\n", mmc_hostname(mmc));
+ mmc->max_blk_size = 0;
+ }
+ }
+
+ mmc->max_blk_size = 512 << mmc->max_blk_size;
/*
* Maximum block count.
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index 2962102..f20a834 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -224,6 +224,8 @@ struct sdhci_host {
#define SDHCI_QUIRK_PIO_NEEDS_DELAY (1<<18)
/* Controller losing signal/interrupt enable states after reset */
#define SDHCI_QUIRK_RESTORE_IRQS_AFTER_RESET (1<<19)
+/* Controller has to be forced to use block size of 2048 bytes */
+#define SDHCI_QUIRK_FORCE_BLK_SZ_2048 (1<<20)
int irq; /* Device IRQ */
void __iomem * ioaddr; /* Mapped address */
--
1.5.6.5
next prev parent reply other threads:[~2009-03-16 21:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 21:13 [PATCH v3 0/11] FSL eSDHC support Anton Vorontsov
2009-03-16 21:13 ` [PATCH 01/11] sdhci: Add support for bus-specific IO memory accessors Anton Vorontsov
2009-03-16 21:13 ` [PATCH 02/11] sdhci: Split card-detection IRQs management from sdhci_init() Anton Vorontsov
2009-03-16 21:13 ` [PATCH 03/11] sdhci: Enable only relevant (DMA/PIO) interrupts during transfers Anton Vorontsov
2009-03-16 21:13 ` [PATCH 04/11] sdhci: Add support for card-detection polling Anton Vorontsov
2009-03-16 21:13 ` [PATCH 05/11] sdhci: Add support for hosts reporting inverted write-protect state Anton Vorontsov
2009-03-16 21:13 ` [PATCH 06/11] sdhci: Add get_{max,timeout}_clock callbacks Anton Vorontsov
2009-03-16 21:13 ` [PATCH 07/11] sdhci: Add set_clock callback and a quirk for nonstandard clocks Anton Vorontsov
2009-03-16 21:14 ` [PATCH 08/11] sdhci: Add quirk for controllers that need small delays for PIO Anton Vorontsov
2009-03-16 21:14 ` [PATCH 09/11] sdhci: Add quirk for controllers that need IRQ re-init after reset Anton Vorontsov
2009-03-16 21:14 ` Anton Vorontsov [this message]
2009-03-16 21:14 ` [PATCH 11/11] mmc: Add OpenFirmware bindings for SDHCI driver Anton Vorontsov
2009-03-19 23:28 ` yamazaki
2009-03-20 22:43 ` Anton Vorontsov
2009-03-21 0:15 ` yamazaki
2009-03-21 0:45 ` Anton Vorontsov
2009-03-21 7:47 ` yamazaki
2009-03-23 6:34 ` 山崎 精二
2009-03-23 16:16 ` Anton Vorontsov
2009-03-24 4:46 ` 山崎 精二
2009-03-23 9:24 ` 山崎 精二
2009-03-22 15:48 ` [PATCH v3 0/11] FSL eSDHC support Pierre Ossman
-- strict thread matches above, loose matches on Subject: below --
2009-03-05 20:27 [PATCH v2 " Anton Vorontsov
2009-03-05 20:28 ` [PATCH 10/11] sdhci: Add quirk for forcing maximum block size to 2048 bytes Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090316211403.GJ9375@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=DaveLiu@freescale.com \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=drzeus-sdhci@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sdhci-devel@list.drzeus.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).