From: David Gibson <david@gibson.dropbear.id.au>
To: Martyn Welch <martyn.welch@gefanuc.com>
Cc: linuxppc-dev@ozlabs.org, wim@iguana.be
Subject: Re: [PATCH v3 1/2] powerpc/86xx: Board support for GE Fanuc's PPC9A
Date: Thu, 19 Mar 2009 11:05:33 +1100 [thread overview]
Message-ID: <20090319000533.GA20163@yookeroo.seuss> (raw)
In-Reply-To: <20090318122914.25609.765.stgit@ubuntu8041.localdomain>
On Wed, Mar 18, 2009 at 12:29:15PM +0000, Martyn Welch wrote:
> Support for the PPC9A VME Single Board Computer from GE Fanuc (PowerPC
> MPC8641D).
>
> This is the basic board support for GE Fanuc's PPC9A, a 6U single board
> computer, based on Freescale's MPC8641D.
One tiny nit left..
[snip]
> + flash@1,0 {
> + compatible = "gef, ppc9a-paged-flash", "cfi-flash";
The space in the compatible string is probably not a good idea.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2009-03-19 0:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 12:29 [PATCH v3 0/2] powerpc/86xx: Board support for GE Fanuc PPC9A Martyn Welch
2009-03-18 12:29 ` [PATCH v3 1/2] powerpc/86xx: Board support for GE Fanuc's PPC9A Martyn Welch
2009-03-18 17:35 ` Wim Van Sebroeck
2009-03-18 17:53 ` Kumar Gala
2009-03-18 18:09 ` Wim Van Sebroeck
2009-03-19 0:05 ` David Gibson [this message]
2009-03-18 12:29 ` [PATCH v3 2/2] powerpc/86xx: Default configuration " Martyn Welch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090319000533.GA20163@yookeroo.seuss \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=martyn.welch@gefanuc.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).