* [PATCH] powerpc/cpm2: fix building fs_enet driver as a module.
@ 2009-03-19 4:21 Grant Likely
2009-03-19 9:02 ` Kumar Gala
0 siblings, 1 reply; 2+ messages in thread
From: Grant Likely @ 2009-03-19 4:21 UTC (permalink / raw)
To: galak, benh, linuxppc-dev
From: Grant Likely <grant.likely@secretlab.ca>
Building the fs_enet driver as a modules fails because it cannot
access the global cpm2_immr symbol.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
Hey Ben and Kumar,
Just found this while testing some unrelated changes. Technically
this is a bug fix that should go into 2.6.29, but it looks like an
old problem and probably nobody is getting bitten by it. I don't
think the world is going to end if it misses the 2.6.29 release.
g.
arch/powerpc/sysdev/cpm2.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/sysdev/cpm2.c b/arch/powerpc/sysdev/cpm2.c
index f1c3395..021480e 100644
--- a/arch/powerpc/sysdev/cpm2.c
+++ b/arch/powerpc/sysdev/cpm2.c
@@ -52,6 +52,7 @@ cpm_cpm2_t __iomem *cpmp; /* Pointer to comm processor space */
* the communication processor devices.
*/
cpm2_map_t __iomem *cpm2_immr;
+EXPORT_SYMBOL(cpm2_immr);
#define CPM_MAP_SIZE (0x40000) /* 256k - the PQ3 reserve this amount
of space for CPM as it is larger
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/cpm2: fix building fs_enet driver as a module.
2009-03-19 4:21 [PATCH] powerpc/cpm2: fix building fs_enet driver as a module Grant Likely
@ 2009-03-19 9:02 ` Kumar Gala
0 siblings, 0 replies; 2+ messages in thread
From: Kumar Gala @ 2009-03-19 9:02 UTC (permalink / raw)
To: Grant Likely; +Cc: linuxppc-dev
On Mar 18, 2009, at 11:21 PM, Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> Building the fs_enet driver as a modules fails because it cannot
> access the global cpm2_immr symbol.
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
>
> Hey Ben and Kumar,
>
> Just found this while testing some unrelated changes. Technically
> this is a bug fix that should go into 2.6.29, but it looks like an
> old problem and probably nobody is getting bitten by it. I don't
> think the world is going to end if it misses the 2.6.29 release.
>
> g.
>
> arch/powerpc/sysdev/cpm2.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
applied to next. (I agree this isn't worth .29 at this point, if
anyone cares they can lobby for it in .29.1)
- k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-19 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-19 4:21 [PATCH] powerpc/cpm2: fix building fs_enet driver as a module Grant Likely
2009-03-19 9:02 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).