From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: TOMARI Hisanobu <posco.grubb@gmail.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: IDE cable detection on Apple PowerBook
Date: Thu, 19 Mar 2009 16:41:13 +0300 [thread overview]
Message-ID: <20090319134113.GA31953@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090319223001.c2674366.posco.grubb@gmail.com>
On Thu, Mar 19, 2009 at 10:30:01PM +0900, TOMARI Hisanobu wrote:
> Thanks for helpful advices.
> This patch adds an option to drivers/ide/Kconfig and adds
> some lines to drivers/ide/pmac.c .
I think it would be better to make it a kernel command line option
instead of Kconfig knob.
The reason is: with distro (pre-compiled) kernels you don't have to
re-compile anything to make the drive work.
The other option is to enable BLK_DEV_IDE_PMAC_SHORTCABLE by default,
but I'm not sure if it's safe thing to do (most probably not).
Thanks for you work on this,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-03-19 13:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 5:06 IDE cable detection on Apple PowerBook TOMARI Hisanobu
2009-03-18 7:58 ` Benjamin Herrenschmidt
2009-03-18 13:47 ` TOMARI Hisanobu
2009-03-19 6:07 ` Benjamin Herrenschmidt
2009-03-19 6:08 ` Benjamin Herrenschmidt
2009-03-19 13:30 ` TOMARI Hisanobu
2009-03-19 13:41 ` Anton Vorontsov [this message]
2009-03-19 21:14 ` Benjamin Herrenschmidt
2009-03-20 6:27 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090319134113.GA31953@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=posco.grubb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).