From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linuxppc-dev@ozlabs.org, Steven Rostedt <srostedt@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency
Date: Fri, 20 Mar 2009 22:39:04 +0300 [thread overview]
Message-ID: <20090320193904.GA13707@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20090320190428.GD6224@elte.hu>
On Fri, Mar 20, 2009 at 08:04:28PM +0100, Ingo Molnar wrote:
>
> * Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
>
> > commit 40ada30f9621fbd831ac2437b9a2a399aad34b00 ("tracing: clean
> > up menu"), despite the "clean up" in its purpose, introduced
> > behavioural change for Kconfig symbols: we no longer able to
> > select tracing support on PPC32 (because IRQFLAGS_SUPPORT isn't
> > yet implemented).
>
> Could you please solve this by implementing proper irqflag-tracing
> support? It's been available upstream for almost three years. It's
> needed for lockdep support as well, etc.
Breaking things via clean up patches is an interesting method of
encouraging something to implement. ;-)
Surely I'll look into implementing irqflags tracing, but considering
that no one ever needed this for almost three years, and that we
explicitly have the code to deal with tracing-w/o-irqflags, can we
please restore the old behaviour?
At least for 2.6.30, because I don't think I'll have enough time to
implement/test/push irqflags tracing support in time for 2.6.30-rc1.
Thanks,
p.s.
It would make more sense if 40ada30f's commit message would state
that tracing w/o irqflags is now obsolete, or better, if it was
discussed on some mailinglist, so that we'd have some time to
adapt the architecture-specific code.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-03-20 19:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 15:09 [PATCH] tracing: Fix TRACING_SUPPORT dependency Anton Vorontsov
2009-03-20 19:04 ` Ingo Molnar
2009-03-20 19:39 ` Anton Vorontsov [this message]
2009-03-20 19:57 ` Ingo Molnar
2009-03-20 20:22 ` Anton Vorontsov
2009-03-21 16:18 ` Ingo Molnar
2009-03-21 16:31 ` Steven Rostedt
2009-03-21 16:33 ` Ingo Molnar
2009-03-21 16:41 ` Steven Rostedt
2009-03-21 16:43 ` Steven Rostedt
2009-03-21 16:46 ` Ingo Molnar
2009-03-23 22:07 ` [PATCH] tracing: Fix TRACING_SUPPORT dependency for PPC32 Anton Vorontsov
2009-03-24 0:51 ` Steven Rostedt
2009-03-24 5:43 ` [PATCH] tracing: Fix TRACING_SUPPORT dependency Benjamin Herrenschmidt
2009-03-21 3:09 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090320193904.GA13707@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).