From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org, monstr@monstr.eu,
linux-kernel@vger.kernel.org, john.williams@petalogix.com
Subject: Re: [PATCH 04/57] microblaze_v7: Open firmware files
Date: Mon, 23 Mar 2009 23:53:05 +0300 [thread overview]
Message-ID: <20090323205305.GA10576@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <200903231951.23902.arnd@arndb.de>
On Mon, Mar 23, 2009 at 07:51:23PM +0100, Arnd Bergmann wrote:
> On Wednesday 18 March 2009, monstr@monstr.eu wrote:
> > From: Michal Simek <monstr@monstr.eu>
> >
> >
> > Signed-off-by: Michal Simek <monstr@monstr.eu>
> > ---
> > arch/microblaze/include/asm/of_device.h | 45 ++
> > arch/microblaze/include/asm/of_platform.h | 64 ++
> > arch/microblaze/include/asm/prom.h | 313 ++++++++
> > arch/microblaze/kernel/of_device.c | 115 +++
> > arch/microblaze/kernel/of_platform.c | 201 +++++
> > arch/microblaze/kernel/prom.c | 1147 +++++++++++++++++++++++++++++
> > arch/microblaze/kernel/prom_parse.c | 1025 ++++++++++++++++++++++++++
> > 7 files changed, 2910 insertions(+), 0 deletions(-)
> > create mode 100644 arch/microblaze/include/asm/of_device.h
> > create mode 100644 arch/microblaze/include/asm/of_platform.h
> > create mode 100644 arch/microblaze/include/asm/prom.h
> > create mode 100644 arch/microblaze/kernel/of_device.c
> > create mode 100644 arch/microblaze/kernel/of_platform.c
> > create mode 100644 arch/microblaze/kernel/prom.c
> > create mode 100644 arch/microblaze/kernel/prom_parse.c
>
> Since these files are derived from the powerpc versions, what is the
> plan on them? IIRC, you had them in a common directory in an earlier
> version. Are you planning to merge them at some point in the future
> or do you intend to maintain a fork?
Actually, it's trivial to factor out all the common code out of
arch/powerpc/ to drivers/of/.
It took me approx. 4 hours to factor out the code and make a
proof-of-concept FDT support for a little-endian ARM platform. ;-)
(The device tree was only describing a cpu and a nor flash, though.
No support for interrupt- and gpio-controllers. And no support for
U-Boot, I just built the dtb file into the kernel).
I never got around to clean it up and send though, but for sure,
there is absolutely no reason to duplicate the code across the
platforms.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-03-23 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1237408284-8674-1-git-send-email-monstr@monstr.eu>
[not found] ` <4b5aee01d11fc790c7842838ea63a82ee3273003.1237407249.git.monstr@monstr.eu>
[not found] ` <af309ba8e95f503b7990461384d9f8453f45dbbd.1237407249.git.monstr@monstr.eu>
2009-03-23 18:51 ` [PATCH 04/57] microblaze_v7: Open firmware files Arnd Bergmann
2009-03-23 20:44 ` Michal Simek
2009-03-23 20:53 ` Anton Vorontsov [this message]
2009-03-26 0:01 ` Benjamin Herrenschmidt
2009-03-24 11:17 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323205305.GA10576@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=arnd@arndb.de \
--cc=john.williams@petalogix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).