* [PATCH] powerpc/83xx: Update ranges in gianfar node to match other dts
@ 2009-03-24 13:35 Kumar Gala
2009-03-24 14:20 ` Anton Vorontsov
2009-03-24 16:00 ` Scott Wood
0 siblings, 2 replies; 5+ messages in thread
From: Kumar Gala @ 2009-03-24 13:35 UTC (permalink / raw)
To: linuxppc-dev
The gianfar node @ 25000 was missing its ranges prop for the mdio bus
and provided an explicit ranges property on gianfar@24000 to match
all other .dts
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
arch/powerpc/boot/dts/mpc8313erdb.dts | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/boot/dts/mpc8313erdb.dts
index 3ebf7ec..20a0fa8 100644
--- a/arch/powerpc/boot/dts/mpc8313erdb.dts
+++ b/arch/powerpc/boot/dts/mpc8313erdb.dts
@@ -180,7 +180,7 @@
#address-cells = <1>;
#size-cells = <1>;
sleep = <&pmc 0x20000000>;
- ranges;
+ ranges = <0x0 0x24000 0x1000>;
cell-index = <0>;
device_type = "network";
@@ -221,6 +221,7 @@
model = "eTSEC";
compatible = "gianfar";
reg = <0x25000 0x1000>;
+ ranges = <0x0 0x25000 0x1000>;
local-mac-address = [ 00 00 00 00 00 00 ];
interrupts = <34 0x8 33 0x8 32 0x8>;
interrupt-parent = <&ipic>;
--
1.5.6.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/83xx: Update ranges in gianfar node to match other dts
2009-03-24 13:35 [PATCH] powerpc/83xx: Update ranges in gianfar node to match other dts Kumar Gala
@ 2009-03-24 14:20 ` Anton Vorontsov
2009-03-24 14:24 ` Kumar Gala
2009-03-24 16:00 ` Scott Wood
1 sibling, 1 reply; 5+ messages in thread
From: Anton Vorontsov @ 2009-03-24 14:20 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
On Tue, Mar 24, 2009 at 08:35:45AM -0500, Kumar Gala wrote:
> The gianfar node @ 25000 was missing its ranges prop for the mdio bus
> and provided an explicit ranges property on gianfar@24000 to match
> all other .dts
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
I think this part is missing:
diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/boot/dts/mpc8313erdb.dts
index 3ebf7ec..98de8bf 100644
--- a/arch/powerpc/boot/dts/mpc8313erdb.dts
+++ b/arch/powerpc/boot/dts/mpc8313erdb.dts
@@ -195,11 +195,11 @@
fixed-link = <1 1 1000 0 0>;
fsl,magic-packet;
- mdio@24520 {
+ mdio@520 {
#address-cells = <1>;
#size-cells = <0>;
compatible = "fsl,gianfar-mdio";
- reg = <0x24520 0x20>;
+ reg = <0x520 0x20>;
phy4: ethernet-phy@4 {
interrupt-parent = <&ipic>;
interrupts = <20 0x8>;
@@ -229,11 +229,11 @@
sleep = <&pmc 0x10000000>;
fsl,magic-packet;
- mdio@25520 {
+ mdio@520 {
#address-cells = <1>;
#size-cells = <0>;
compatible = "fsl,gianfar-tbi";
- reg = <0x25520 0x20>;
+ reg = <0x520 0x20>;
tbi1: tbi-phy@11 {
reg = <0x11>;
> arch/powerpc/boot/dts/mpc8313erdb.dts | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/boot/dts/mpc8313erdb.dts
> index 3ebf7ec..20a0fa8 100644
> --- a/arch/powerpc/boot/dts/mpc8313erdb.dts
> +++ b/arch/powerpc/boot/dts/mpc8313erdb.dts
> @@ -180,7 +180,7 @@
> #address-cells = <1>;
> #size-cells = <1>;
> sleep = <&pmc 0x20000000>;
> - ranges;
> + ranges = <0x0 0x24000 0x1000>;
>
> cell-index = <0>;
> device_type = "network";
> @@ -221,6 +221,7 @@
> model = "eTSEC";
> compatible = "gianfar";
> reg = <0x25000 0x1000>;
> + ranges = <0x0 0x25000 0x1000>;
> local-mac-address = [ 00 00 00 00 00 00 ];
> interrupts = <34 0x8 33 0x8 32 0x8>;
> interrupt-parent = <&ipic>;
> --
> 1.5.6.6
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] powerpc/83xx: Update ranges in gianfar node to match other dts
2009-03-24 14:20 ` Anton Vorontsov
@ 2009-03-24 14:24 ` Kumar Gala
0 siblings, 0 replies; 5+ messages in thread
From: Kumar Gala @ 2009-03-24 14:24 UTC (permalink / raw)
To: avorontsov; +Cc: linuxppc-dev
On Mar 24, 2009, at 9:20 AM, Anton Vorontsov wrote:
> On Tue, Mar 24, 2009 at 08:35:45AM -0500, Kumar Gala wrote:
>> The gianfar node @ 25000 was missing its ranges prop for the mdio bus
>> and provided an explicit ranges property on gianfar@24000 to match
>> all other .dts
>>
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>> ---
>
> I think this part is missing:
>
> diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/
> boot/dts/mpc8313erdb.dts
> index 3ebf7ec..98de8bf 100644
> --- a/arch/powerpc/boot/dts/mpc8313erdb.dts
> +++ b/arch/powerpc/boot/dts/mpc8313erdb.dts
> @@ -195,11 +195,11 @@
> fixed-link = <1 1 1000 0 0>;
> fsl,magic-packet;
>
> - mdio@24520 {
> + mdio@520 {
> #address-cells = <1>;
> #size-cells = <0>;
> compatible = "fsl,gianfar-mdio";
> - reg = <0x24520 0x20>;
> + reg = <0x520 0x20>;
> phy4: ethernet-phy@4 {
> interrupt-parent = <&ipic>;
> interrupts = <20 0x8>;
> @@ -229,11 +229,11 @@
> sleep = <&pmc 0x10000000>;
> fsl,magic-packet;
>
> - mdio@25520 {
> + mdio@520 {
> #address-cells = <1>;
> #size-cells = <0>;
> compatible = "fsl,gianfar-tbi";
> - reg = <0x25520 0x20>;
> + reg = <0x520 0x20>;
>
> tbi1: tbi-phy@11 {
> reg = <0x11>;
>>
yep, sending a new version
- k
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/83xx: Update ranges in gianfar node to match other dts
2009-03-24 13:35 [PATCH] powerpc/83xx: Update ranges in gianfar node to match other dts Kumar Gala
2009-03-24 14:20 ` Anton Vorontsov
@ 2009-03-24 16:00 ` Scott Wood
2009-03-24 17:42 ` Kumar Gala
1 sibling, 1 reply; 5+ messages in thread
From: Scott Wood @ 2009-03-24 16:00 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
On Tue, Mar 24, 2009 at 08:35:45AM -0500, Kumar Gala wrote:
> The gianfar node @ 25000 was missing its ranges prop for the mdio bus
> and provided an explicit ranges property on gianfar@24000 to match
> all other .dts
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> arch/powerpc/boot/dts/mpc8313erdb.dts | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/boot/dts/mpc8313erdb.dts
> index 3ebf7ec..20a0fa8 100644
> --- a/arch/powerpc/boot/dts/mpc8313erdb.dts
> +++ b/arch/powerpc/boot/dts/mpc8313erdb.dts
> @@ -180,7 +180,7 @@
> #address-cells = <1>;
> #size-cells = <1>;
> sleep = <&pmc 0x20000000>;
> - ranges;
> + ranges = <0x0 0x24000 0x1000>;
>
> cell-index = <0>;
> device_type = "network";
You need to fix the reg property of the child node to match this change
in ranges. Was this boot-tested (or is it a case of Linux's device tree
parsing being excessively tolerant of broken trees)?
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/83xx: Update ranges in gianfar node to match other dts
2009-03-24 16:00 ` Scott Wood
@ 2009-03-24 17:42 ` Kumar Gala
0 siblings, 0 replies; 5+ messages in thread
From: Kumar Gala @ 2009-03-24 17:42 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev
On Mar 24, 2009, at 11:00 AM, Scott Wood wrote:
> On Tue, Mar 24, 2009 at 08:35:45AM -0500, Kumar Gala wrote:
>> The gianfar node @ 25000 was missing its ranges prop for the mdio bus
>> and provided an explicit ranges property on gianfar@24000 to match
>> all other .dts
>>
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>> ---
>> arch/powerpc/boot/dts/mpc8313erdb.dts | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/
>> boot/dts/mpc8313erdb.dts
>> index 3ebf7ec..20a0fa8 100644
>> --- a/arch/powerpc/boot/dts/mpc8313erdb.dts
>> +++ b/arch/powerpc/boot/dts/mpc8313erdb.dts
>> @@ -180,7 +180,7 @@
>> #address-cells = <1>;
>> #size-cells = <1>;
>> sleep = <&pmc 0x20000000>;
>> - ranges;
>> + ranges = <0x0 0x24000 0x1000>;
>>
>> cell-index = <0>;
>> device_type = "network";
>
> You need to fix the reg property of the child node to match this
> change
> in ranges. Was this boot-tested (or is it a case of Linux's device
> tree
> parsing being excessively tolerant of broken trees)?
>
I didn't boot test.. Anton pointed this issue out as well.
- k
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-03-24 17:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-24 13:35 [PATCH] powerpc/83xx: Update ranges in gianfar node to match other dts Kumar Gala
2009-03-24 14:20 ` Anton Vorontsov
2009-03-24 14:24 ` Kumar Gala
2009-03-24 16:00 ` Scott Wood
2009-03-24 17:42 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).