From: David Miller <davem@davemloft.net>
To: joakim.tjernlund@transmode.se
Cc: netdev@vger.kernel.org, leoli@freescale.com, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.
Date: Wed, 25 Mar 2009 14:39:39 -0700 (PDT) [thread overview]
Message-ID: <20090325.143939.207077477.davem@davemloft.net> (raw)
In-Reply-To: <1237987849.2194.9.camel@gentoo-jocke.transmode.se>
From: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Date: Wed, 25 Mar 2009 14:30:49 +0100
> >From 1c2f23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 2001
> From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> Date: Tue, 24 Mar 2009 10:19:27 +0100
> Subject: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.
> Also increase NAPI weight somewhat.
> This will make the system alot more responsive while
> ping flooding the ucc_geth ethernet interaface.
>
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
The weight is not for the sake of your device, it's for
the sake of fairness with others.
Please just use 64, like every other driver does.
I'm not applying this.
next prev parent reply other threads:[~2009-03-25 21:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 13:30 [PATCH] ucc_geth: Move freeing of TX packets to NAPI context Joakim Tjernlund
2009-03-25 14:04 ` Eric Dumazet
2009-03-25 15:16 ` Joakim Tjernlund
2009-03-25 21:42 ` David Miller
2009-03-25 21:40 ` David Miller
2009-03-25 21:55 ` Joakim Tjernlund
2009-03-25 14:25 ` Anton Vorontsov
2009-03-25 15:21 ` Joakim Tjernlund
2009-03-25 17:51 ` Joakim Tjernlund
2009-03-30 8:34 ` Li Yang
2009-03-30 9:21 ` Joakim Tjernlund
2009-03-30 9:36 ` Li Yang
2009-03-30 10:01 ` Joakim Tjernlund
2009-03-30 10:24 ` Li Yang
2009-03-30 20:36 ` David Miller
2009-03-25 21:39 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-04-17 22:03 Anton Vorontsov
2009-04-21 9:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325.143939.207077477.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joakim.tjernlund@transmode.se \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).