From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: leoli@freescale.com, netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.
Date: Wed, 25 Mar 2009 14:40:41 -0700 (PDT) [thread overview]
Message-ID: <20090325.144041.128558998.davem@davemloft.net> (raw)
In-Reply-To: <49CA39EA.6020208@cosmosbay.com>
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Wed, 25 Mar 2009 15:04:26 +0100
> Joakim Tjernlund a =E9crit :
> > + /* Tx event processing */
> > + spin_lock(&ugeth->lock);
> > + for (i =3D 0; i < ug_info->numQueuesTx; i++) {
> > + ucc_geth_tx(ugeth->dev, i);
> > + }
> > + spin_unlock(&ugeth->lock);
> > +
> =
> Why tx completions dont change "howmany" ?
> It seems strange you changed UCC_GETH_DEV_WEIGHT if not taking into a=
ccount tx event above...
He should leave howmany alone for TX work and use a weight
value of 64 just like most other drivers in the tree do.
Due to the abuse and random ignorant fiddling of the
weight value, I am going to make it something the core
rather than drivers choose.
next prev parent reply other threads:[~2009-03-25 21:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 13:30 [PATCH] ucc_geth: Move freeing of TX packets to NAPI context Joakim Tjernlund
2009-03-25 14:04 ` Eric Dumazet
2009-03-25 15:16 ` Joakim Tjernlund
2009-03-25 21:42 ` David Miller
2009-03-25 21:40 ` David Miller [this message]
2009-03-25 21:55 ` Joakim Tjernlund
2009-03-25 14:25 ` Anton Vorontsov
2009-03-25 15:21 ` Joakim Tjernlund
2009-03-25 17:51 ` Joakim Tjernlund
2009-03-30 8:34 ` Li Yang
2009-03-30 9:21 ` Joakim Tjernlund
2009-03-30 9:36 ` Li Yang
2009-03-30 10:01 ` Joakim Tjernlund
2009-03-30 10:24 ` Li Yang
2009-03-30 20:36 ` David Miller
2009-03-25 21:39 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-04-17 22:03 Anton Vorontsov
2009-04-21 9:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325.144041.128558998.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dada1@cosmosbay.com \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).