From: David Miller <davem@davemloft.net>
To: Joakim.Tjernlund@transmode.se
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
leoli@freescale.com, dada1@cosmosbay.com
Subject: Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.
Date: Wed, 25 Mar 2009 14:42:07 -0700 (PDT) [thread overview]
Message-ID: <20090325.144207.225365184.davem@davemloft.net> (raw)
In-Reply-To: <OF73F7C45F.ACAACBF8-ONC1257584.0052EC21-C1257584.0053E5EF@transmode.se>
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Date: Wed, 25 Mar 2009 16:16:24 +0100
> UCC_GETH_DEV_WEIGHT needs to be a bit bigger than the number of RX
> HW buffers avaliable, otherwise one won't be able to drain the whole
> queue in one go. Changing weight to something bigger made a big
> difference.
You're not supposed to "drain the whole queue in one go", that
is not the goal of the weight value.
The goal of the weight value is that it is low enough such that
other devices also scheduled for NAPI on the current processor
can get some fair time to process packets too.
next prev parent reply other threads:[~2009-03-25 21:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 13:30 [PATCH] ucc_geth: Move freeing of TX packets to NAPI context Joakim Tjernlund
2009-03-25 14:04 ` Eric Dumazet
2009-03-25 15:16 ` Joakim Tjernlund
2009-03-25 21:42 ` David Miller [this message]
2009-03-25 21:40 ` David Miller
2009-03-25 21:55 ` Joakim Tjernlund
2009-03-25 14:25 ` Anton Vorontsov
2009-03-25 15:21 ` Joakim Tjernlund
2009-03-25 17:51 ` Joakim Tjernlund
2009-03-30 8:34 ` Li Yang
2009-03-30 9:21 ` Joakim Tjernlund
2009-03-30 9:36 ` Li Yang
2009-03-30 10:01 ` Joakim Tjernlund
2009-03-30 10:24 ` Li Yang
2009-03-30 20:36 ` David Miller
2009-03-25 21:39 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-04-17 22:03 Anton Vorontsov
2009-04-21 9:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325.144207.225365184.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Joakim.Tjernlund@transmode.se \
--cc=dada1@cosmosbay.com \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).