From: David Miller <davem@davemloft.net>
To: Joakim.Tjernlund@transmode.se
Cc: linuxppc-dev@ozlabs.org, leoli@freescale.com, pku.leo@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.
Date: Mon, 30 Mar 2009 13:36:48 -0700 (PDT) [thread overview]
Message-ID: <20090330.133648.202747210.davem@davemloft.net> (raw)
In-Reply-To: <OF42785A57.F2F3AFE4-ONC1257589.0035B462-C1257589.003712D0@transmode.se>
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Date: Mon, 30 Mar 2009 12:01:33 +0200
> I don't know. But the question you should ask is: Does the networking
> code promise this now and for the future? If not, you should
> fix the driver not to relay on netif_queue_stopped() here.
Stop this nonsense talk.
If the driver can't be the one and only controller of the TX queue
state, everything would essentially explode.
The fact is, it does.
next prev parent reply other threads:[~2009-03-30 20:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 13:30 [PATCH] ucc_geth: Move freeing of TX packets to NAPI context Joakim Tjernlund
2009-03-25 14:04 ` Eric Dumazet
2009-03-25 15:16 ` Joakim Tjernlund
2009-03-25 21:42 ` David Miller
2009-03-25 21:40 ` David Miller
2009-03-25 21:55 ` Joakim Tjernlund
2009-03-25 14:25 ` Anton Vorontsov
2009-03-25 15:21 ` Joakim Tjernlund
2009-03-25 17:51 ` Joakim Tjernlund
2009-03-30 8:34 ` Li Yang
2009-03-30 9:21 ` Joakim Tjernlund
2009-03-30 9:36 ` Li Yang
2009-03-30 10:01 ` Joakim Tjernlund
2009-03-30 10:24 ` Li Yang
2009-03-30 20:36 ` David Miller [this message]
2009-03-25 21:39 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-04-17 22:03 Anton Vorontsov
2009-04-21 9:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090330.133648.202747210.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Joakim.Tjernlund@transmode.se \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pku.leo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).