* [PATCH] fsl_pq_mdio: Revive UCC MDIO support
@ 2009-03-31 18:33 Anton Vorontsov
2009-04-02 8:28 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Anton Vorontsov @ 2009-03-31 18:33 UTC (permalink / raw)
To: David Miller
Cc: netdev, Li Yang, Andy Fleming, Joakim Tjernlund, linuxppc-dev
commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 ("netdev: Merge UCC
and gianfar MDIO bus drivers") introduced a regression so that UCC
MDIO buses no longer work.
This is because fsl_pq_mdio driver wrongly masks all non-TBI PHYs
for !fsl,gianfar-mdio buses, while it should do that only for
fsl,gianfar-tbi buses.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
drivers/net/fsl_pq_mdio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c
index b3079a5..d9e1ecf 100644
--- a/drivers/net/fsl_pq_mdio.c
+++ b/drivers/net/fsl_pq_mdio.c
@@ -387,7 +387,7 @@ static int fsl_pq_mdio_probe(struct of_device *ofdev,
* The TBIPHY-only buses will find PHYs at every address,
* so we mask them all but the TBI
*/
- if (!of_device_is_compatible(np, "fsl,gianfar-mdio"))
+ if (of_device_is_compatible(np, "fsl,gianfar-tbi"))
new_bus->phy_mask = ~(1 << tbiaddr);
err = mdiobus_register(new_bus);
--
1.5.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fsl_pq_mdio: Revive UCC MDIO support
2009-03-31 18:33 [PATCH] fsl_pq_mdio: Revive UCC MDIO support Anton Vorontsov
@ 2009-04-02 8:28 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-04-02 8:28 UTC (permalink / raw)
To: avorontsov; +Cc: netdev, leoli, afleming, Joakim.Tjernlund, linuxppc-dev
From: Anton Vorontsov <avorontsov@ru.mvista.com>
Date: Tue, 31 Mar 2009 22:33:52 +0400
> commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 ("netdev: Merge UCC
> and gianfar MDIO bus drivers") introduced a regression so that UCC
> MDIO buses no longer work.
>
> This is because fsl_pq_mdio driver wrongly masks all non-TBI PHYs
> for !fsl,gianfar-mdio buses, while it should do that only for
> fsl,gianfar-tbi buses.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-02 8:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-31 18:33 [PATCH] fsl_pq_mdio: Revive UCC MDIO support Anton Vorontsov
2009-04-02 8:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).