From: Arnd Bergmann <arnd@arndb.de>
To: Harry Ciao <qingtao.cao@windriver.com>
Cc: linuxppc-dev@ozlabs.org, norsk5@yahoo.com,
linux-kernel@vger.kernel.org,
bluesmoke-devel@lists.sourceforge.net
Subject: Re: [v0 PATCH 2/5] EDAC: Add CPC925 driver source file
Date: Thu, 2 Apr 2009 14:40:16 +0200 [thread overview]
Message-ID: <200904021440.17366.arnd@arndb.de> (raw)
In-Reply-To: <1238652440-9224-3-git-send-email-qingtao.cao@windriver.com>
On Thursday 02 April 2009, Harry Ciao wrote:
> Introduce IBM CPC925 EDAC driver source file, which makes use of error
> detections on the IBM CPC925 Bridge and Memory Controller.
>
> Signed-off-by: Harry Ciao <qingtao.cao@windriver.com>
On a very brief review, the driver looks good to me, but please
post the full series to the linuxppc-dev@ozlabs.org mailing list
as well, because that is likely to have more people that will
comment on it.
The first three patches of your series should be merged into
a single one, because none of them has any signficance by itself.
You may also consider moving the contents of the header file
into the main driver, because it does not actually act as an
interface.
Arnd <><
prev parent reply other threads:[~2009-04-02 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1238652440-9224-1-git-send-email-qingtao.cao@windriver.com>
[not found] ` <1238652440-9224-5-git-send-email-qingtao.cao@windriver.com>
[not found] ` <1238652440-9224-6-git-send-email-qingtao.cao@windriver.com>
2009-04-02 12:36 ` [v0 PATCH 5/5] EDAC: CPC925 MC platform device setup Arnd Bergmann
2009-04-03 3:17 ` Harry Ciao
2009-04-03 5:49 ` Harry Ciao
[not found] ` <1238652440-9224-2-git-send-email-qingtao.cao@windriver.com>
[not found] ` <1238652440-9224-3-git-send-email-qingtao.cao@windriver.com>
2009-04-02 12:40 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904021440.17366.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=norsk5@yahoo.com \
--cc=qingtao.cao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).