linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: linuxppc-dev@ozlabs.org
Cc: Eddie Dawydiuk <eddie@embeddedarm.com>
Subject: Re: AMCC 440EP phy detection
Date: Wed, 8 Apr 2009 18:01:27 +0200	[thread overview]
Message-ID: <200904081801.27754.sr@denx.de> (raw)
In-Reply-To: <49DCC6FA.1050708@embeddedarm.com>

On Wednesday 08 April 2009, Eddie Dawydiuk wrote:
> > I found the ibm_newemac driver(2.6.29) makes the assumption that the
> > bootloader has already configured the tx enable pin as it is a
> > multiplexed pin. Unfortuantley I am not using U-Boot and our minimal
> > bootloader does not do this.  After finding tx enable was never
> > asserting for Eth0 a quick user space program verified tx enable was
> > configured as a GPIO pin.
>
> I would like to eventually submit our changes for upstream support. Based
> on this would you recommend ensuring tx enable is configured properly in
> the initialization of the ibm_newemac driver or the platform
> initialization?

This GPIO multiplexing configuration does not belong into the ibm_newemac 
driver since it is very platform/board specific. The platform code is 
definitely a better place.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de
=====================================================================

  reply	other threads:[~2009-04-08 16:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-07 16:32 AMCC 440EP phy detection Eddie Dawydiuk
2009-04-07 16:47 ` Feng Kan
2009-04-07 18:20   ` Eddie Dawydiuk
2009-04-07 17:11 ` Grant Likely
2009-04-07 17:18   ` Stefan Roese
2009-04-08  0:10   ` Eddie Dawydiuk
2009-04-08 15:47     ` Eddie Dawydiuk
2009-04-08 16:01       ` Stefan Roese [this message]
2009-04-08 17:00         ` Grant Likely
2009-04-08 18:19           ` Stefan Roese
2009-04-08 18:35             ` Eddie Dawydiuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904081801.27754.sr@denx.de \
    --to=sr@denx.de \
    --cc=eddie@embeddedarm.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).