linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sean MacLennan <smaclennan@pikatech.com>
To: "Trent Piepho" <xyzzy@speakeasy.org>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] powerpc: Update Warp to use leds-gpio driver
Date: Sat, 18 Apr 2009 00:37:45 -0400	[thread overview]
Message-ID: <20090418003745.7dce8f47@lappy.seanm.ca> (raw)
In-Reply-To: <Pine.LNX.4.64.0904172008310.5178@t2.domain.actdsltmp>

On Fri, 17 Apr 2009 20:12:50 -0700 (PDT)
"Trent Piepho" <xyzzy@speakeasy.org> wrote:

> On Mon, 6 Apr 2009, Sean MacLennan wrote:
> > Now that leds-gpio is a proper OF platform driver, the Warp can use
> > the leds-gpio driver rather than the old out-of-kernel driver.
> >
> > One side-effect is the leds-gpio driver always turns the leds off
> > while the old driver left them alone. So we have to set them back to
> > the correct settings.  
> 
> Originally, I had the OF bindings support this feature, see
> http://article.gmane.org/gmane.linux.kernel/749094
> 
> Maybe this would be a better way to do it?  It avoids the glitch in
> the leds, is less code overall, and can be use by other devices that
> might want this same behavior.

Yes, that is a cleaner way to handle the LEDs. Do you know why this
patch wasn't accepted at the time? A quick google shows that Grant
Likely acked it.

The patch will no longer apply since default state does not exist.

Cheers,
   Sean

  reply	other threads:[~2009-04-18  4:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090406175825.76bb969c__7633.03726348585$1239055251$gmane$org@lappy.seanm.ca>
2009-04-18  3:12 ` [PATCH] powerpc: Update Warp to use leds-gpio driver Trent Piepho
2009-04-18  4:37   ` Sean MacLennan [this message]
2009-04-18  5:07     ` Grant Likely
2009-05-12 22:33       ` [PATCH] leds: Add options to have GPIO LEDs start on or keep their state Trent Piepho
2009-05-12 23:14         ` Sean MacLennan
2009-05-13  9:13         ` Wolfram Sang
2009-05-13 18:54           ` Trent Piepho
2009-04-06 21:58 [PATCH] powerpc: Update Warp to use leds-gpio driver Sean MacLennan
2009-04-18  0:41 ` Sean MacLennan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090418003745.7dce8f47@lappy.seanm.ca \
    --to=smaclennan@pikatech.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=xyzzy@speakeasy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).