From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from services.gcu-squad.org (zone0.gcu-squad.org [212.85.147.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0AC1FDDFAE for ; Tue, 21 Apr 2009 19:23:16 +1000 (EST) Date: Tue, 21 Apr 2009 11:23:00 +0200 From: Jean Delvare To: Takashi Iwai Subject: Re: [PATCH] keywest: Convert to new-style i2c driver Message-ID: <20090421112300.467e9f9b@hyperion.delvare> In-Reply-To: References: <20090420225659.7b92a184@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 21 Apr 2009 08:31:00 +0200, Takashi Iwai wrote: > At Mon, 20 Apr 2009 22:56:59 +0200, > Jean Delvare wrote: > > > > The legacy i2c binding model is going away soon, so convert the ppc > > keywest sound driver to the new model or it will break. > > > > Signed-off-by: Jean Delvare > > Cc: Benjamin Herrenschmidt > > Cc: Takashi Iwai > > --- > > Takashi, please push this patch to Linus quickly, as this is blocking > > the removal of the legacy i2c binding model, which is scheduled for > > 2.6.30. > > > > I did not get any test report for this one, but it's relatively simple > > so I am confident I got it right. > > Applied this one, too. Thanks. Thanks Takashi. BTW, I forgot to mention again that the new i2c binding model is functional since kernel 2.6.25, so for the external alsa driver tree you will want to guard these changes with appropriate ifdef magic. -- Jean Delvare