From: Grant Likely <grant.likely@secretlab.ca>
To: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
Andy Fleming <afleming@freescale.com>,
David Miller <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: [PATCH v3 13/13] net: fix fsl_pq_mdio driver to use module_init()
Date: Sat, 25 Apr 2009 16:53:44 -0600 [thread overview]
Message-ID: <20090425225344.32392.18956.stgit@localhost.localdomain> (raw)
In-Reply-To: <20090425224458.32392.31296.stgit@localhost.localdomain>
From: Grant Likely <grant.likely@secretlab.ca>
Modules are not supposed to use any of the *_initcall*() hooks as
the entry point. fsl_pq_mdio.c was using subsys_initcall_sync()
instead of module_init() to guarantee that the MDIO bus was initialized
before the Ethernet driver goes looking for the phy. However, the recent
OF helpers rework happens to also make sure PHY connection is deferred to
.open time, so using an initcall is no longer necessary.
This patch replaces the initcall with a more traditional an accepted
module_init() call.
Tested on Freescale MPC8349emitxgp eval board.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
drivers/net/fsl_pq_mdio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c
index b01daa1..d12e0e0 100644
--- a/drivers/net/fsl_pq_mdio.c
+++ b/drivers/net/fsl_pq_mdio.c
@@ -415,10 +415,10 @@ int __init fsl_pq_mdio_init(void)
{
return of_register_platform_driver(&fsl_pq_mdio_driver);
}
+module_init(fsl_pq_mdio_init);
void fsl_pq_mdio_exit(void)
{
of_unregister_platform_driver(&fsl_pq_mdio_driver);
}
-subsys_initcall_sync(fsl_pq_mdio_init);
module_exit(fsl_pq_mdio_exit);
next prev parent reply other threads:[~2009-04-25 22:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-25 22:52 [PATCH 00/13] OF device tree handling of PHY drivers Grant Likely
2009-04-25 22:52 ` [PATCH v3 01/13] of: add of_parse_phandle() helper for parsing phandle properties Grant Likely
2009-04-25 22:52 ` [PATCH v3 02/13] phylib: rework to prepare for OF registration of PHYs Grant Likely
2009-04-25 22:52 ` [PATCH v3 03/13] phylib: add *_direct() variants of phy_connect and phy_attach functions Grant Likely
2009-04-25 22:52 ` [PATCH v3 04/13] openfirmware: Add OF phylib support code Grant Likely
2009-04-25 22:53 ` [PATCH v3 05/13] net: Rework mpc5200 fec driver to use of_mdio infrastructure Grant Likely
2009-04-25 22:53 ` [PATCH v3 06/13] net: rework fsl_pq_mdio " Grant Likely
2009-04-25 22:53 ` [PATCH v3 07/13] net: Rework gianfar " Grant Likely
2009-04-25 22:53 ` [PATCH v3 08/13] net: Rework pasemi_mac " Grant Likely
2009-04-25 22:53 ` [PATCH v3 09/13] net: Rework ucc_geth " Grant Likely
2009-04-26 9:00 ` Joakim Tjernlund
2009-04-27 15:36 ` Grant Likely
2009-04-25 22:53 ` [PATCH v3 10/13] powerpc/82xx: Rework Embedded Planet ep8248e platform to use of_mdio Grant Likely
2009-04-25 22:53 ` [PATCH v3 11/13] net: Rework fs_enet driver to use of_mdio infrastructure Grant Likely
2009-04-25 22:53 ` [PATCH v3 12/13] net: add Xilinx ll_temac device driver Grant Likely
2009-04-25 22:53 ` Grant Likely [this message]
2009-04-27 9:54 ` [PATCH 00/13] OF device tree handling of PHY drivers David Miller
2009-04-27 13:07 ` Grant Likely
2009-04-27 17:17 ` Grant Likely
2009-05-04 23:14 ` Scott Wood
2009-05-05 1:55 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090425225344.32392.18956.stgit@localhost.localdomain \
--to=grant.likely@secretlab.ca \
--cc=afleming@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).