From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org, linuxppc-dev@ozlabs.org,
rpurdie@linux.intel.com, tpiepho@freescale.com,
smaclennan@pikatech.com
Subject: Re: "leds: Add openfirmware platform device support" breaks sparc
Date: Mon, 27 Apr 2009 15:20:51 -0700 [thread overview]
Message-ID: <20090427152051.5067e888.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090303.163713.131742043.davem@davemloft.net>
On Tue, 03 Mar 2009 16:37:13 -0800 (PST)
David Miller <davem@davemloft.net> wrote:
> From: Sean MacLennan <smaclennan@pikatech.com>
> Date: Tue, 3 Mar 2009 19:29:32 -0500
>
> > It has been..... uhhhh carry the two... longer than I want to admit
> > since I worked on a sparc. Would GPIO based LEDS make sense on a sparc
> > platform? Is sparc used much in the embedded world?
> >
> > If yes, the of_register_platform_driver is just a nice wrapper. It
> > would be trivial to either change it to work on sparc, or add the
> > wrapper to the sparc includes.
>
> We generally create the platform devices by hand for LED
> devices on sparc64.
>
> I'd CONFIG_POWERPC depend this thing for now.
Nobody has done this, so current mainline's sparc64 allmodconfig remains
busted.
This?
--- a/drivers/leds/Kconfig~a
+++ a/drivers/leds/Kconfig
@@ -139,6 +139,7 @@ config LEDS_GPIO_PLATFORM
config LEDS_GPIO_OF
bool "OpenFirmware platform device bindings for GPIO LEDs"
depends on LEDS_GPIO && OF_DEVICE
+ depends on POWERPC
default y
help
Let the leds-gpio driver drive LEDs which have been defined as
_
next prev parent reply other threads:[~2009-04-27 22:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 0:09 "leds: Add openfirmware platform device support" breaks sparc Andrew Morton
2009-03-04 0:15 ` Grant Likely
2009-03-04 0:28 ` Andrew Morton
2009-03-04 0:29 ` Sean MacLennan
2009-03-04 0:37 ` David Miller
2009-04-27 22:20 ` Andrew Morton [this message]
2009-04-28 3:59 ` Grant Likely
2009-04-28 9:01 ` David Miller
2009-03-04 0:40 ` Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090427152051.5067e888.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=rpurdie@linux.intel.com \
--cc=smaclennan@pikatech.com \
--cc=sparclinux@vger.kernel.org \
--cc=tpiepho@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).