From: David Miller <davem@davemloft.net>
To: leoli@freescale.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, akpm@linux-foundation.org
Subject: Re: [PATCH] rio: warn_unused_result warnings fix
Date: Tue, 28 Apr 2009 04:38:23 -0700 (PDT) [thread overview]
Message-ID: <20090428.043823.244762395.davem@davemloft.net> (raw)
In-Reply-To: <2a27d3730904280408j636d8e4tc1b6e1c827509379@mail.gmail.com>
From: Li Yang <leoli@freescale.com>
Date: Tue, 28 Apr 2009 19:08:13 +0800
> IMHO, when device_add() fails the system is quite broken. So the
> value is very limited for it to fail cleanly, which need some effort
> to implement. I can add it if you insist.
I disagree.
For the cases where device_add() fails (duplicate name, for
example) the device layer already is emitting warnings.
You're just adding more log messages for the user to sift
through, and likely not adding any new information.
next prev parent reply other threads:[~2009-04-28 11:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 10:16 [PATCH 0/5] rapidio: adding memory mapping IO support and misc fixes Li Yang
2009-04-28 10:15 ` [PATCH] rapidio: add common mapping APIs for RapidIO memory access Li Yang
2009-04-28 10:15 ` [PATCH] powerpc/fsl_rio: use LAW address from device tree Li Yang
2009-04-28 10:15 ` [PATCH] powerpc: add memory map support to Freescale RapioIO block Li Yang
2009-04-28 10:15 ` [PATCH] rionet: add memory access to simulated Ethernet over rapidio Li Yang
2009-04-28 10:15 ` [PATCH] rio: warn_unused_result warnings fix Li Yang
2009-04-28 10:51 ` Michael Ellerman
2009-04-28 11:08 ` Li Yang
2009-04-28 11:38 ` David Miller [this message]
2009-04-28 11:39 ` [PATCH] rapidio: add common mapping APIs for RapidIO memory access David Miller
2009-04-30 5:10 ` Li Yang
2009-04-30 11:45 ` Kumar Gala
2009-04-28 12:06 ` [PATCH 0/5] rapidio: adding memory mapping IO support and misc fixes Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428.043823.244762395.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).