From: Stefan Roscher <ossrosch@linux.vnet.ibm.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: fenkes@de.ibm.com, LKML <linux-kernel@vger.kernel.org>,
LinuxPPC-Dev <linuxppc-dev@ozlabs.org>,
raisch@de.ibm.com, alexschm@de.ibm.com,
stefan.roscher@de.ibm.com
Subject: Re: [PATCH 1/3] IB/ehca: Replace vmalloc with kmalloc
Date: Tue, 28 Apr 2009 18:02:47 +0200 [thread overview]
Message-ID: <200904281802.47809.ossrosch@linux.vnet.ibm.com> (raw)
In-Reply-To: <1240931572.29485.77.camel@nimitz>
On Tuesday 28 April 2009 05:12:51 pm Dave Hansen wrote:
> On Tue, 2009-04-21 at 17:16 +0200, Stefan Roscher wrote:
> > From: Anton Blanchard <antonb at au1.ibm.com>
> >
> > To improve performance of driver ressource allocation,
> > replace the vmalloc() call with kmalloc().
>
> Just curious, but how big are these allocations? Why was vmalloc() even
> ever used if we know they'll be small?
>
> -- Dave
>
>
The theoretical maximum size can be 512k, but for common queue pairs
less than 128k is used.Because of the theoretical maximum we implemented
vmalloc() first, but recognized a huge performance impact.
-- Stefan
next prev parent reply other threads:[~2009-04-28 16:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 15:16 [PATCH 1/3] IB/ehca: Replace vmalloc with kmalloc Stefan Roscher
2009-04-21 17:34 ` Roland Dreier
2009-04-22 9:11 ` Stefan Roscher
2009-04-22 14:02 ` Stefan Roscher
2009-04-22 14:10 ` michael
2009-04-22 16:00 ` Stefan Roscher
2009-04-22 16:12 ` michael
2009-04-28 13:07 ` [ewg] " Alexander Schmidt
2009-04-28 14:01 ` Roland Dreier
2009-04-28 14:13 ` Alexander Schmidt
2009-04-28 15:12 ` Dave Hansen
2009-04-28 16:02 ` Stefan Roscher [this message]
2009-04-28 16:45 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904281802.47809.ossrosch@linux.vnet.ibm.com \
--to=ossrosch@linux.vnet.ibm.com \
--cc=alexschm@de.ibm.com \
--cc=dave@linux.vnet.ibm.com \
--cc=fenkes@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=raisch@de.ibm.com \
--cc=stefan.roscher@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).