From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pfepb.post.tele.dk (pfepb.post.tele.dk [195.41.46.236]) by ozlabs.org (Postfix) with ESMTP id 41243DDDB6 for ; Fri, 1 May 2009 19:19:13 +1000 (EST) Date: Fri, 1 May 2009 11:21:14 +0200 From: Sam Ravnborg To: Tim Abbott Subject: Re: [PATCH v2 2/6] Add new NOSAVE_DATA linker script macro. Message-ID: <20090501092114.GC18326@uranus.ravnborg.org> References: <1241121253-32341-1-git-send-email-tabbott@mit.edu> <1241121253-32341-2-git-send-email-tabbott@mit.edu> <1241121253-32341-3-git-send-email-tabbott@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1241121253-32341-3-git-send-email-tabbott@mit.edu> Cc: linux-mips@linux-mips.org, linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Denys Vlasenko , Greg Ungerer , Jeff Arnold , linuxppc-dev@ozlabs.org, Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Waseem Daher , linux-s390@vger.kernel.org, Jesper Nilsson , Yoshinori Sato , Helge Deller , Ingo Molnar , Geert Uytterhoeven , microblaze-uclinux@itee.uq.edu.au, Russell King , user-mode-linux-devel@lists.sourceforge.net, Heiko Carstens , Jeff Dike , dev-etrax@axis.com, Mikael Starvik , Cyrill Gorcunov , Michal Simek , Richard Henderson , Chris Zankel , Bryan Wu , Tony Luck , linux-parisc@vger.kernel.org, Haavard Skinnemoen , Hirokazu Takata , Linux kernel mailing list , Ralf Baechle , Anders Kaseorg , Kyle McMartin , Paul Mundt , Thomas Gleixner , linux-alpha@vger.kernel.org, Martin Schwidefsky , uclinux-dist-devel@blackfin.uclinux.org, Linus Torvalds , "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Apr 30, 2009 at 03:54:09PM -0400, Tim Abbott wrote: > This patch is preparation for replacing most ".data.nosave" in the > kernel with macros, so that the section name can later be changed > without having to touch a lot of the kernel. > > The long-term goal here is to be able to change the kernel's magic > section names to those that are compatible with -ffunction-sections > -fdata-sections. This requires renaming all magic sections with names > of the form ".data.foo". > > Signed-off-by: Tim Abbott > Cc: Sam Ravnborg > --- > include/asm-generic/vmlinux.lds.h | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > index 3d88c87..f5ebd2b 100644 > --- a/include/asm-generic/vmlinux.lds.h > +++ b/include/asm-generic/vmlinux.lds.h > @@ -124,6 +124,13 @@ > . = ALIGN(PAGE_SIZE); \ > *(.bss.page_aligned) > > +#define NOSAVE_DATA \ > + . = ALIGN(PAGE_SIZE); \ > + __nosave_begin = .; \ > + *(.data.nosave) \ > + . = ALIGN(PAGE_SIZE); \ > + __nosave_end = .; > + You need to use: VMLINUX_SYMBOL(__nosave_begin) = .; Otherwise architectures such as m68k wil break as they add a leading underscore. See other symbols that is defined inside vmlinux.lds.h Sam