From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pfepa.post.tele.dk (pfepa.post.tele.dk [195.41.46.235]) by ozlabs.org (Postfix) with ESMTP id 8B74ADDD1B for ; Fri, 1 May 2009 19:42:05 +1000 (EST) Date: Fri, 1 May 2009 11:44:07 +0200 From: Sam Ravnborg To: Tim Abbott , Christoph Lameter Subject: Re: [PATCH 6/6] Add support for __read_mostly to linux/cache.h Message-ID: <20090501094407.GD18326@uranus.ravnborg.org> References: <1241119956-31453-1-git-send-email-tabbott@mit.edu> <1241119956-31453-2-git-send-email-tabbott@mit.edu> <1241119956-31453-3-git-send-email-tabbott@mit.edu> <1241119956-31453-4-git-send-email-tabbott@mit.edu> <1241119956-31453-5-git-send-email-tabbott@mit.edu> <1241119956-31453-6-git-send-email-tabbott@mit.edu> <1241119956-31453-7-git-send-email-tabbott@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1241119956-31453-7-git-send-email-tabbott@mit.edu> Cc: linux-mips@linux-mips.org, linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Denys Vlasenko , Greg Ungerer , Jeff Arnold , linuxppc-dev@ozlabs.org, Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Waseem Daher , linux-arm-kernel@lists.arm.linux.org.uk, linux-s390@vger.kernel.org, Jesper Nilsson , linux-am33-list@redhat.com, Yoshinori Sato , Helge Deller , Ingo Molnar , Geert Uytterhoeven , microblaze-uclinux@itee.uq.edu.au, Russell King , user-mode-linux-devel@lists.sourceforge.net, Heiko Carstens , Jeff Dike , dev-etrax@axis.com, Mikael Starvik , Tony Luck , Cyrill Gorcunov , Michal Simek , Richard Henderson , Chris Zankel , Bryan Wu , linux-m32r@ml.linux-m32r.org, linux-parisc@vger.kernel.org, Haavard Skinnemoen , Hirokazu Takata , Ralf Baechle , Anders Kaseorg , Kyle McMartin , Paul Mundt , Thomas Gleixner , linux-alpha@vger.kernel.org, Martin Schwidefsky , uclinux-dist-devel@blackfin.uclinux.org, Linus Torvalds , "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Apr 30, 2009 at 03:32:36PM -0400, Tim Abbott wrote: > Signed-off-by: Tim Abbott > --- > include/linux/cache.h | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/include/linux/cache.h b/include/linux/cache.h > index 97e2488..99d8a6f 100644 > --- a/include/linux/cache.h > +++ b/include/linux/cache.h > @@ -13,7 +13,13 @@ > #endif > > #ifndef __read_mostly > +#ifdef CONFIG_HAVE_READ_MOSTLY_DATA > +#define __read_mostly __attribute__((__section__(".data.read_mostly"))) > +#define __READ_MOSTLY .section ".data.read_mostly", "aw" > +#else > #define __read_mostly > +#define __READ_MOSTLY > +#endif /* CONFIG_HAVE_READ_MOSTLY_DATA */ > #endif Are there any specific reason why we do not support read_mostly on all architectures? read_mostly is about grouping rarely written data together so what is needed is to introduce this section in the remaining archtectures. Christoph - git log says you did the inital implmentation. Do you agree? Sam