From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: linux-fbdev-devel@lists.sourceforge.net,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
cbe-oss-dev@ozlabs.org
Subject: Re: [PATCH 08/15] powerpc/cell: Extract duplicated IOPTE_* to <asm/iommu.h>
Date: Sun, 10 May 2009 21:08:26 +0200 [thread overview]
Message-ID: <20090510190825.GB23659@lst.de> (raw)
In-Reply-To: <1241791284-11490-9-git-send-email-Geert.Uytterhoeven@sonycom.com>
On Fri, May 08, 2009 at 04:01:17PM +0200, Geert Uytterhoeven wrote:
> +/* Cell page table entries */
> +#define IOPTE_PP_W 0x8000000000000000ul /* protection: write */
> +#define IOPTE_PP_R 0x4000000000000000ul /* protection: read */
> +#define IOPTE_M 0x2000000000000000ul /* coherency required */
> +#define IOPTE_SO_R 0x1000000000000000ul /* ordering: writes */
> +#define IOPTE_SO_RW 0x1800000000000000ul /* ordering: r & w */
> +#define IOPTE_RPN_Mask 0x07fffffffffff000ul /* RPN */
> +#define IOPTE_H 0x0000000000000800ul /* cache hint */
> +#define IOPTE_IOID_Mask 0x00000000000007fful /* ioid */
If this is in a global header it should probably have a CELL_ prefix.
next prev parent reply other threads:[~2009-05-10 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1241791284-11490-1-git-send-email-Geert.Uytterhoeven@sonycom.com>
[not found] ` <1241791284-11490-2-git-send-email-Geert.Uytterhoeven@sonycom.com>
[not found] ` <1241791284-11490-3-git-send-email-Geert.Uytterhoeven@sonycom.com>
[not found] ` <1241791284-11490-4-git-send-email-Geert.Uytterhoeven@sonycom.com>
[not found] ` <1241791284-11490-5-git-send-email-Geert.Uytterhoeven@sonycom.com>
[not found] ` <1241791284-11490-6-git-send-email-Geert.Uytterhoeven@sonycom.com>
[not found] ` <1241791284-11490-7-git-send-email-Geert.Uytterhoeven@sonycom.com>
[not found] ` <1241791284-11490-8-git-send-email-Geert.Uytterhoeven@sonycom.com>
2009-05-08 14:01 ` [PATCH 08/15] powerpc/cell: Extract duplicated IOPTE_* to <asm/iommu.h> Geert Uytterhoeven
2009-05-10 19:08 ` Christoph Hellwig [this message]
2009-05-11 7:24 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090510190825.GB23659@lst.de \
--to=hch@lst.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=arnd@arndb.de \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox