From: Andrew Morton <akpm@linux-foundation.org>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: sfr@canb.auug.org.au, linuxppc-dev@ozlabs.org
Subject: Re: drivers/video/logo/logo_linux_mono.c build error
Date: Wed, 13 May 2009 15:44:15 -0700 [thread overview]
Message-ID: <20090513154415.fd10762c.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LRH.2.00.0904280922410.31001@vixen.sonytel.be>
On Tue, 28 Apr 2009 09:24:53 +0200 (CEST)
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
> On Tue, 28 Apr 2009, Stephen Rothwell wrote:
> > On Mon, 27 Apr 2009 14:50:31 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> > > powerpc allmodconfig, current mainline:
> > >
> > > drivers/video/logo/logo_linux_mono.c:11: error: logo_linux_mono_data causes a section type conflict
> > >
> > > switching it from __initconst to __initdata "fixes" it.
> >
> > Interesting. The program that generates the .c file above produces
> > __initdata for me ...
>
> I assume Andrew once built in that tree using the recent logo patches that
> 1. Makes the logos const and switch them from __initdata to __initconst,
> 2. Fix the missing dependency of the generated files on the generator program.
> Hence if you revert the logo patches, you have to manually remove the generated
> files.
>
> Is my assumption correct?
Nope - mrproper removes every .c file from drivers/video/logo/ apart
from logo.c
The failure is caused by your fbdev-move-logo-externs-to-header-file.patch.
Without that patch, drivers/video/logo/logo_linux_mono.c is generated as
static unsigned char logo_linux_mono_data[] __initdata = {
and with that patch, drivers/video/logo/logo_linux_mono.c is generated as
static const unsigned char logo_linux_mono_data[] __initconst = {
and it's the switch from __initdata to __initconst which causes this
section conflict in my setup.
next prev parent reply other threads:[~2009-05-13 22:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 21:50 drivers/video/logo/logo_linux_mono.c build error Andrew Morton
2009-04-28 3:52 ` Stephen Rothwell
2009-04-28 7:24 ` Geert Uytterhoeven
2009-05-13 22:44 ` Andrew Morton [this message]
2009-05-14 7:24 ` Geert Uytterhoeven
2009-05-26 11:52 ` Geert Uytterhoeven
2009-05-26 17:26 ` Andrew Morton
2009-04-29 5:42 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090513154415.fd10762c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).