linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Gabriel Paubert <paubert@iram.es>
To: Matt Sealey <matt@genesi-usa.com>
Cc: LinuxPPC <linuxppc-dev@ozlabs.org>
Subject: [RFC] How to allow selecting mv643xx_eth on Pegasos again
Date: Thu, 14 May 2009 08:48:36 +0200	[thread overview]
Message-ID: <20090514064836.GA21486@iram.es> (raw)

On Thu, Jan 08, 2009 at 11:53:10PM -0600, Matt Sealey wrote:
> Lennert Buytenhek wrote:
>> On Thu, Jan 08, 2009 at 11:38:33PM -0600, Matt Sealey wrote:
>>
>> On this topic, I sent a patch to linuxppc-dev@ some time ago that moves
>> the mv643xx_eth SRAM window programming code from the Pegasos platform
>> code to the mv643xx_eth driver, and adds a couple of fields to the
>> mv643xx_eth platform data that lets you pass the sram addresses/sizes
>> in.  Since I don't have the hardware I haven't been able to test it,
>> but it would be nice if someone could.
>
> It seems to work. However it's still static stuff in some platform  
> driver, which I don't really like. pegasos_eth.c is really a holdover  
> from the very early days of ppc->powerpc architecture port, where they  
> insisted that we do detection that way (and fudge it based on host  
> controller PCI ID)
>
> The Pegasos device tree is so screwed up, you could never gain the  
> information you need from it. And times have changed..

I just tried to compile a very recent kernel for my Pegasoi, and
I can no more select the MV643XX_ETH driver. The root cause is that
PPC_MULTIPLATFORM has been removed. There are several possibilities:

1) remove simply the PPC_MULTIPLATFORM and let it depends on PPC32

2) replace PPC_MULTIPLATFORM && PPC32 by 6xx which is apparently the
   blessed way of doing this. But I dislike a 6xx condition in anything
   outside arch/powerpc.

3) add a select statement for MV64X60 in CHRP. It will bring in more
   code and would probably need an OF node for the system controller.
   I suspect that the mv64x60 pic and i2c are not wired on Pegasos.

Pick your poison...

While at it, I'm also going to remove the last remnants of MV64360
since it is never selected anywhere (replaced by MV64X60).  

	Regards,
	Gabriel

P.S.: this is not sufficient, after this the driver crashes at initialization
but that's a separate patch, that has to do with the dma mapping interface.

             reply	other threads:[~2009-05-14  6:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14  6:48 Gabriel Paubert [this message]
2009-05-14  8:59 ` [RFC] How to allow selecting mv643xx_eth on Pegasos again Simon Richter
2009-05-14  9:09   ` Gabriel Paubert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090514064836.GA21486@iram.es \
    --to=paubert@iram.es \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=matt@genesi-usa.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).