linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Gabriel Paubert <paubert@iram.es>
To: Medve Emilian-EMMEDVE1 <Emilian.Medve@freescale.com>
Cc: netdev@vger.kernel.org, tbm@cyrius.com,
	LinuxPPC <linuxppc-dev@ozlabs.org>,
	pacman@kosh.dhis.org, David Miller <davem@davemloft.net>,
	Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH] Allow selecting mv643xx_eth on Pegasos again
Date: Mon, 18 May 2009 20:47:52 +0200	[thread overview]
Message-ID: <20090518184752.GA12972@iram.es> (raw)
In-Reply-To: <598D5675D34BE349929AF5EDE9B03E2702C2D323@az33exm24.fsl.freescale.net>

On Mon, May 18, 2009 at 10:48:58AM -0700, Medve Emilian-EMMEDVE1 wrote:
> > -----Original Message-----
> > From: linuxppc-dev-bounces+emilian.medve=freescale.com@ozlabs.org
> [mailto:linuxppc-dev-
> > bounces+emilian.medve=freescale.com@ozlabs.org] On Behalf Of Gabriel
> Paubert
> > Sent: Monday, May 18, 2009 12:38 PM
> > To: Lennert Buytenhek
> > Cc: tbm@cyrius.com; LinuxPPC; pacman@kosh.dhis.org;
> netdev@vger.kernel.org; David Miller
> > Subject: [PATCH] Allow selecting mv643xx_eth on Pegasos again
> > 
> > Since PPC_MUTIPLATFORM was removed, it was impossible to select the
> > driver for mv643xx_eth on the Pegasos. Fix by allowing to select
> > the driver on CHRP platforms; Pegasos is a CHRP platform and the
> driver
> > will not work without arch/powerpc/platforms/chrp/pegasos_eth.
> > 
> > Signed-off-by: Gabriel Paubert <paubert@iram.es>
> > 
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index 214a92d..6fc0ff4 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -2351,7 +2351,7 @@ config UGETH_TX_ON_DEMAND
> > 
> >  config MV643XX_ETH
> >  	tristate "Marvell Discovery (643XX) and Orion ethernet support"
> > -	depends on MV64360 || MV64X60 || (PPC_MULTIPLATFORM && PPC32) ||
> PLAT_ORION
> > +	depends on MV64X60 || PPC_CHRP || PLAT_ORION
> >  	select INET_LRO
> >  	select PHYLIB
> >  	help
> 
> This got fixed here:
> http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commi
> tdiff;h=952ee9df26c487f2d73b2dced58ec904f19ea0f8

Ok, I was not aware of it, but the fact is that MV64360 no more exists
and the only non MV64X60 platform that may need it is the Pegasos (to my
knowledge) and it relies on some platform specific code enabled
by PPC_CHRP.

	Regards,
	Gabriel

  reply	other threads:[~2009-05-18 18:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18 17:37 [PATCH] Allow selecting mv643xx_eth on Pegasos again Gabriel Paubert
2009-05-18 17:48 ` Medve Emilian-EMMEDVE1
2009-05-18 18:47   ` Gabriel Paubert [this message]
2009-05-18 20:15     ` Medve Emilian-EMMEDVE1
2009-05-18 22:18       ` Gabriel Paubert
2009-05-18 22:53         ` Medve Emilian-EMMEDVE1
2009-05-18 23:21           ` [PATCH v2] " Gabriel Paubert
2009-05-19  2:35             ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2009-05-15 18:18 [PATCH] " Gabriel Paubert
2009-05-18  3:24 ` Benjamin Herrenschmidt
2009-05-18 17:33   ` Gabriel Paubert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090518184752.GA12972@iram.es \
    --to=paubert@iram.es \
    --cc=Emilian.Medve@freescale.com \
    --cc=buytenh@wantstofly.org \
    --cc=davem@davemloft.net \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=pacman@kosh.dhis.org \
    --cc=tbm@cyrius.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).