From: David Miller <davem@davemloft.net>
To: a.beregalov@gmail.com
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org
Subject: Re: [PATCH] powerpc/ep8248e: phylib needs NET_SCHED to build
Date: Wed, 20 May 2009 12:26:22 -0700 (PDT) [thread overview]
Message-ID: <20090520.122622.112939264.davem@davemloft.net> (raw)
In-Reply-To: <1242821902-16836-1-git-send-email-a.beregalov@gmail.com>
From: Alexander Beregalov <a.beregalov@gmail.com>
Date: Wed, 20 May 2009 16:18:22 +0400
> Fix this build error:
> drivers/built-in.o: In function `phy_state_machine':
> drivers/net/phy/phy.c:893: undefined reference to 'netif_carrier_off'
> drivers/net/phy/phy.c:854: undefined reference to 'netif_carrier_on'
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
This isn't right. Otherwise no networking driver would build
with NET_SCHED disabled.
net/sched/sch_generic.c is always built when NET is enabled
and that's where netif_carrier_off() is defined.
As you can see in net/sched/Makefile, sch_generic.o is
"obj-y", did you even check? :-)
prev parent reply other threads:[~2009-05-20 19:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 12:18 [PATCH] powerpc/ep8248e: phylib needs NET_SCHED to build Alexander Beregalov
2009-05-20 12:27 ` Geert Uytterhoeven
2009-05-20 13:27 ` Kumar Gala
2009-05-20 19:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520.122622.112939264.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.beregalov@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).