From: "Piotr Zięcik" <kosmo@semihalf.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Becky Bruce <Becky.Bruce@freescale.com>,
Wolfgang Denk <wd@denx.de>, Detlev Zundel <dzu@denx.de>,
John Rigby <jrigby@gmail.com>,
netdev@vger.kernel.org, linuxppc-dev@ozlabs.org,
Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH 02/12] fs_enet: Add MPC5121 FEC support.
Date: Thu, 21 May 2009 10:34:39 +0200 [thread overview]
Message-ID: <200905211034.39762.kosmo@semihalf.com> (raw)
In-Reply-To: <fa686aa40905140700k3ca28ac0m74c9c161ad538abc@mail.gmail.com>
Thursday 14 May 2009 16:00:33 Grant Likely wrote:
> > MPC5121 support was added to drivers/net/fs_enet. MPC52xx uses
> > drivers/net/fec_mpc52xx.c. Do you think that creating one universal
> > driver from these two is now possible? You said that it should be easy,
> > however you also said that cache coherency issues makes this imposible.
>
> Not impossible. Hard.
I thought a bit more about merging FEC drivers and I see one problem more.
Driver fs_enet works with FEC's with own DMA engine and fec_mpc52xx.c uses
BestComm. Integration of these two drivers will need a DMA abstraction layer
to keep everything clean. Unfortuanetly BestComm driver does not provide any
abstraction - it only exports set of functions to deal with specific
hardware: FEC and PATA.
More #ifdef's will be needed to remove linking with BestComm driver if kernel
will be compiled without 52xx support and resulting code will not be much
better than existing one. Especially that new DMA abstraction layer probably
will be quite complex.
--
Best Regards.
Piotr Ziecik
next prev parent reply other threads:[~2009-05-21 8:36 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 20:15 [PATCH 00/16] Add support for MPC512x Wolfgang Denk
2009-05-06 20:15 ` [PATCH 01/12] fs_enet: Use defines to set driver tunables Wolfgang Denk
2009-05-06 20:35 ` Grant Likely
2009-05-06 22:02 ` Wolfgang Denk
2009-05-06 22:41 ` Grant Likely
2009-05-06 20:15 ` [PATCH 02/12] fs_enet: Add MPC5121 FEC support Wolfgang Denk
2009-05-06 20:33 ` Grant Likely
2009-05-06 21:08 ` Scott Wood
2009-05-06 22:01 ` Wolfgang Denk
2009-05-06 22:29 ` Grant Likely
2009-05-06 22:41 ` Wolfgang Denk
2009-05-07 14:09 ` Grant Likely
2009-05-08 2:02 ` John Rigby
2009-05-08 7:52 ` David Miller
2009-05-11 6:56 ` David Jander
2009-05-07 8:14 ` David Jander
2009-05-07 13:05 ` Kumar Gala
2009-05-06 20:40 ` David Miller
2009-05-06 22:06 ` Wolfgang Denk
2009-05-06 20:41 ` Scott Wood
2009-05-06 22:09 ` Wolfgang Denk
2009-05-06 22:39 ` Grant Likely
2009-05-14 12:38 ` Piotr Zięcik
2009-05-14 14:00 ` Grant Likely
2009-05-18 22:17 ` Benjamin Herrenschmidt
2009-05-19 11:26 ` Piotr Zięcik
2009-05-19 21:56 ` Benjamin Herrenschmidt
2009-05-21 8:34 ` Piotr Zięcik [this message]
2009-05-21 15:36 ` Grant Likely
2009-05-06 20:15 ` [PATCH 03/12] fs_enet: Add FEC TX Alignment workaround for MPC5121 Wolfgang Denk
2009-05-06 20:37 ` Grant Likely
2009-05-06 22:12 ` Wolfgang Denk
2009-05-06 22:42 ` Grant Likely
2009-05-08 2:36 ` John Rigby
2009-05-06 20:15 ` [PATCH 04/12] mpc5121: Added reset module registers representation Wolfgang Denk
2009-05-06 20:29 ` Scott Wood
2009-05-06 21:57 ` Wolfgang Denk
2009-05-06 20:39 ` Grant Likely
2009-05-06 22:14 ` Wolfgang Denk
2009-05-06 20:15 ` [PATCH 05/12] mpc5121ads: Added Reset Module node to DTS Wolfgang Denk
2009-05-06 20:40 ` Grant Likely
2009-05-06 22:16 ` Wolfgang Denk
2009-05-06 22:46 ` Grant Likely
2009-05-06 20:15 ` [PATCH 06/12] mpc5121: Added NAND Flash Controller driver Wolfgang Denk
2009-05-06 20:59 ` Grant Likely
2009-05-08 2:22 ` John Rigby
2009-05-08 3:07 ` Grant Likely
2009-05-07 8:08 ` David Jander
2009-05-08 3:30 ` John Rigby
2009-05-13 8:41 ` Piotr Zięcik
2009-05-06 20:15 ` [PATCH 07/12] mpc5121ads: Clean up and fix NAND description in mpc5121ads DTS Wolfgang Denk
2009-05-06 21:00 ` Grant Likely
2009-05-06 20:15 ` [PATCH 08/12] mpc5121: Added I2C support Wolfgang Denk
2009-05-06 21:01 ` Grant Likely
2009-05-06 22:19 ` Wolfgang Denk
2009-05-06 22:51 ` Grant Likely
2009-05-07 2:41 ` Grant Likely
2009-05-07 6:36 ` Wolfgang Grandegger
2009-05-18 13:57 ` Piotr Zięcik
2009-05-18 14:11 ` Grant Likely
2009-05-18 14:29 ` Wolfgang Grandegger
2009-05-19 7:47 ` Piotr Zięcik
2009-05-19 8:10 ` Wolfgang Grandegger
2009-05-08 2:12 ` John Rigby
2009-05-08 3:01 ` Grant Likely
2009-05-06 20:15 ` [PATCH 09/12] mpc5121ads: Added I2C RTC node to mpc5121ads DTS Wolfgang Denk
2009-05-06 21:02 ` Grant Likely
2009-05-07 6:45 ` Wolfgang Grandegger
2009-05-06 20:15 ` [PATCH 10/12] mpc5121: Add MPC5121 Real time clock driver Wolfgang Denk
2009-05-06 21:03 ` Grant Likely
2009-05-06 21:06 ` Wolfram Sang
2009-05-06 22:40 ` Grant Likely
2009-05-08 2:41 ` [rtc-linux] " John Rigby
2009-05-08 15:53 ` Grant Likely
2009-05-08 16:09 ` Alessandro Zummo
2009-05-08 19:18 ` Wolfgang Denk
2009-05-08 16:10 ` Alessandro Zummo
2009-05-06 20:15 ` [PATCH 11/12] mpc5121: Added MPC512x DMA driver Wolfgang Denk
2009-05-06 21:07 ` Grant Likely
2009-05-08 2:49 ` John Rigby
2009-05-19 1:37 ` Hongjun Chen
2009-05-19 8:03 ` Piotr Zięcik
2009-05-20 0:39 ` Hongjun Chen
2009-05-06 20:15 ` [PATCH 12/12] mpc5121: Added default config for MPC5121 Wolfgang Denk
2009-05-06 21:08 ` Grant Likely
2009-05-06 22:23 ` Wolfgang Denk
2009-05-06 22:48 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905211034.39762.kosmo@semihalf.com \
--to=kosmo@semihalf.com \
--cc=Becky.Bruce@freescale.com \
--cc=dzu@denx.de \
--cc=grant.likely@secretlab.ca \
--cc=jrigby@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).