linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Linux Netdev List <netdev@vger.kernel.org>,
	devicetree-discuss@ozlabs.org
Subject: Re: [net-next-2.6 PATCH v2] can: SJA1000: generic OF platform bus driver
Date: Sun, 24 May 2009 23:27:14 +0100	[thread overview]
Message-ID: <200905242327.15139.arnd@arndb.de> (raw)
In-Reply-To: <4A18298E.8090209@grandegger.com>

On Saturday 23 May 2009, Wolfgang Grandegger wrote:
> Arnd Bergmann wrote:
> > 
> > Minor nitpicking: dev->base_addr should be defined as an __iomem pointer
> > so you can avoid the cast here and in the ioremap/iounmap path.
> 
> Here the member "base_addr" of "struct net_device" is used and it's not
> up to me to change the type.

Right, that makes sense. However, most drivers use the field to store the
physical address, not the iomap token. Maybe there should be a new field
in struct sja1000_priv for the virtual address, but that would be a change
to the base driver, not just to the OF portion.

Thanks,

	Arnd <><

  reply	other threads:[~2009-05-24 22:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-22 14:46 [net-next-2.6 PATCH v2] can: SJA1000: generic OF platform bus driver Wolfgang Grandegger
2009-05-22 15:08 ` Grant Likely
2009-05-23  6:29   ` Wolfgang Grandegger
2009-05-23 16:44     ` Wolfgang Grandegger
2009-05-25  6:53       ` Grant Likely
2009-05-25  8:15         ` Wolfgang Grandegger
2009-05-23 11:15 ` Arnd Bergmann
2009-05-23 16:51   ` Wolfgang Grandegger
2009-05-24 22:27     ` Arnd Bergmann [this message]
2009-05-25  6:58       ` Wolfgang Grandegger
2009-05-26  9:10         ` Arnd Bergmann
2009-05-26  9:25           ` David Miller
2009-05-26  9:42             ` Arnd Bergmann
2009-05-26 11:20               ` Sascha Hauer
2009-05-26 14:23             ` Wolfgang Grandegger
2009-05-30 17:59               ` Wolfgang Grandegger
2009-05-26  9:40           ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905242327.15139.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=devicetree-discuss@ozlabs.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).