* [PATCH net] gianfar: fix babbling rx error event bug
@ 2009-05-27 1:52 Xiaotian Feng
2009-05-27 3:48 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Xiaotian Feng @ 2009-05-27 1:52 UTC (permalink / raw)
To: galak, davem, netdev; +Cc: linuxppc-dev, linux-kernel
Gianfar interrupt handler uses IEVENT_ERR_MASK to check and handle errors.
Babbling RX error (IEVENT_BABR) should be included in IEVENT_ERROR_MASK.
Otherwise if BABR is raised, it never gets handled nor cleared, and an
interrupt storm results. This has been observed to happen on sending a
burst of ethernet frames to a gianfar based board.
Signed-off-by: Xiaotian Feng <xiaotian.feng@windriver.com>
---
drivers/net/gianfar.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/gianfar.h b/drivers/net/gianfar.h
index 0642d52..cf35296 100644
--- a/drivers/net/gianfar.h
+++ b/drivers/net/gianfar.h
@@ -259,7 +259,7 @@ extern const char gfar_driver_version[];
(IEVENT_RXC | IEVENT_BSY | IEVENT_EBERR | IEVENT_MSRO | \
IEVENT_BABT | IEVENT_TXC | IEVENT_TXE | IEVENT_LC \
| IEVENT_CRL | IEVENT_XFUN | IEVENT_DPE | IEVENT_PERR \
- | IEVENT_MAG)
+ | IEVENT_MAG | IEVENT_BABR)
#define IMASK_INIT_CLEAR 0x00000000
#define IMASK_BABR 0x80000000
--
1.5.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] gianfar: fix babbling rx error event bug
2009-05-27 1:52 [PATCH net] gianfar: fix babbling rx error event bug Xiaotian Feng
@ 2009-05-27 3:48 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-05-27 3:48 UTC (permalink / raw)
To: Xiaotian.Feng; +Cc: netdev, linux-kernel, linuxppc-dev
From: Xiaotian Feng <Xiaotian.Feng@windriver.com>
Date: Wed, 27 May 2009 09:52:36 +0800
> Gianfar interrupt handler uses IEVENT_ERR_MASK to check and handle errors.
> Babbling RX error (IEVENT_BABR) should be included in IEVENT_ERROR_MASK.
> Otherwise if BABR is raised, it never gets handled nor cleared, and an
> interrupt storm results. This has been observed to happen on sending a
> burst of ethernet frames to a gianfar based board.
>
> Signed-off-by: Xiaotian Feng <xiaotian.feng@windriver.com>
Patch applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-27 3:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-27 1:52 [PATCH net] gianfar: fix babbling rx error event bug Xiaotian Feng
2009-05-27 3:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).