linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sean MacLennan <smaclennan@pikatech.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: powerpc: DMA coherent allocations broken for CONFIG_NOT_COHERENT_CACHE
Date: Thu, 28 May 2009 01:00:00 -0400	[thread overview]
Message-ID: <20090528010000.31423083@lappy.seanm.ca> (raw)
In-Reply-To: <fa686aa40905272042yd7b4698gbd1133b4c61c9b87@mail.gmail.com>

On Wed, 27 May 2009 21:42:18 -0600
Grant Likely <grant.likely@secretlab.ca> wrote:

> Make your driver use a platform device or an of_platform device.  It's
> not at all hard.

Here is my first shot.... any other fields that I need to fill in so I
don't have any gotchas?

/* This must exist */
static void warp_device_release(struct device *dev) {}

static struct platform_device warp_device = {
	.name = "warp-device",
	.id = 0,
	.num_resources = 0,
	.dev = {
		.coherent_dma_mask = ~0ULL,
		.release = warp_device_release,
	},
};


	platform_device_register(&warp_device);

Cheers,
   Sean

  reply	other threads:[~2009-05-28  5:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-21 16:50 powerpc: DMA coherent allocations broken for CONFIG_NOT_COHERENT_CACHE Albert Herranz
2009-05-24  6:47 ` Grant Likely
2009-05-24 10:21   ` Benjamin Herrenschmidt
2009-05-25  0:21     ` Benjamin Herrenschmidt
2009-05-25  1:43       ` Arnd Bergmann
2009-05-25  4:19         ` Benjamin Herrenschmidt
2009-05-25  4:33         ` Benjamin Herrenschmidt
2009-05-25  5:50           ` Grant Likely
2009-05-25  6:49             ` Benjamin Herrenschmidt
2009-05-28  3:34           ` Sean MacLennan
2009-05-28  3:42             ` Grant Likely
2009-05-28  5:00               ` Sean MacLennan [this message]
2009-05-28  5:09                 ` Grant Likely
2009-05-28  3:52             ` Benjamin Herrenschmidt
2009-05-28  4:11               ` Sean MacLennan
2009-05-28  4:19                 ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2009-05-26 17:13 Albert Herranz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090528010000.31423083@lappy.seanm.ca \
    --to=smaclennan@pikatech.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).