linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: John Rigby <jcrigby@gmail.com>, Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, Chen Hongjun <Hong-jun.chen@freecale.com>
Subject: Re: [PATCH 05/04] *** NOT FOR RELEASE *** HACK *** Work around MII clock issue ***
Date: Sun, 07 Jun 2009 22:34:06 +0200	[thread overview]
Message-ID: <20090607203406.7C8BC832E416@gemini.denx.de> (raw)
In-Reply-To: <4b73d43f0906061708o763409d0u10a344dfc30e32c1@mail.gmail.com>

Dear John,

in message <4b73d43f0906061708o763409d0u10a344dfc30e32c1@mail.gmail.com> you wrote:
>
> > The big question seems to be what the RefMan means when talking about
> > the "system clock frequency". Obiously it is NOT  the  CPU  clock  as
...
> > But which one is it?
> 
> My best guess is still that it is ips clock.  I think I stated in a previous
> email ipb, but I meant ips.  5200 has ibp and 5121 has ips.  Have you looked
> at he MII clock on a scope to see how the calculated values compare to
> actual?

Yes, it seems very much as if you were right again.

When using ips/ibp everything makes sense, and works.

Hm... so that means on MPC512x we should use mpc512x_find_ips_freq(),
while on MPC5200 we should use  mpc52xx_find_ipb_freq()  -  but  hey,
apart from the name these two functions are identical.

Grant - how would you like to see this handled? Should we merge these
two code-wise identical functions into one?  What should be the name,
and in which file should we put it?

[We need this clock thing for "drivers/net/fs_enet/mii-fec.c"...]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"Don't think; let the machine do it for you!"        - E. C. Berkeley

  parent reply	other threads:[~2009-06-07 20:34 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-06 20:20 [PATCH 00/04] Add support for ARIA board Wolfgang Denk
2009-05-06 20:20 ` [PATCH 01/04] mpc5121: prepare support for additional boards Wolfgang Denk
2009-05-06 20:29   ` Grant Likely
2009-05-06 20:40     ` Wolfgang Denk
2009-05-06 21:11       ` Grant Likely
2009-05-06 20:20 ` [PATCH 02/04] ARIA: add device tree source file Wolfgang Denk
2009-05-06 20:21 ` [PATCH 03/04] mpc5121: add support for ARIA board Wolfgang Denk
2009-05-06 20:21 ` [PATCH 04/04] ARIA: add default config file Wolfgang Denk
2009-05-06 20:21 ` [PATCH 05/04] *** NOT FOR RELEASE *** HACK *** Work around MII clock issue *** Wolfgang Denk
2009-05-07  8:26   ` Joakim Tjernlund
2009-05-07  9:19     ` Wolfgang Denk
2009-05-07  9:30       ` Joakim Tjernlund
2009-05-08  2:09   ` John Rigby
2009-06-06 22:16     ` Wolfgang Denk
2009-06-06 22:27       ` John Rigby
2009-06-06 23:21         ` Wolfgang Denk
2009-06-07  0:08           ` John Rigby
2009-06-07  8:20             ` Wolfram Sang
2009-06-07 20:34             ` Wolfgang Denk [this message]
2009-06-08  7:46               ` Wolfgang Grandegger
2009-06-08  8:19                 ` Wolfgang Denk
2009-06-08 14:39                   ` Grant Likely
2009-06-08 14:37               ` Grant Likely
2009-06-11 20:19                 ` [PATCH] mpc5xxx_get_bus_frequency(): use common code on MPC512x and MPC52xx Wolfgang Denk
2009-06-17  6:14                   ` Grant Likely
2009-06-17  6:21                     ` Grant Likely
2009-06-11 20:19                 ` [PATCH RFC] fs_enet/mii-fec.c: fix MII speed calculation Wolfgang Denk
2009-07-14 13:42                   ` [PATCH v2] " Wolfgang Denk
2009-07-15 15:18                     ` [PATCH 1/2 v3] " Wolfgang Denk
2009-07-15 17:17                       ` Grant Likely
2009-07-16 21:21                         ` Wolfgang Denk
2009-07-16 22:37                           ` Grant Likely
2009-07-16 21:42                       ` [PATCH 1/2 v4] " Wolfgang Denk
2009-07-16 22:44                         ` Grant Likely
2009-07-17 12:24                           ` Wolfgang Denk
2009-07-17  9:33                         ` Wolfram Sang
2009-07-17 12:32                           ` Wolfgang Denk
2009-07-17 12:27                         ` [PATCH 1/2 v5] " Wolfgang Denk
2009-07-17 14:41                           ` Grant Likely
2009-07-17 16:21                             ` David Miller
2009-07-17 16:48                             ` David Miller
2009-07-17 12:27                         ` [PATCH 2/2 v3] MPC52xx FEC: be more conservative when setting MII_SPEED register Wolfgang Denk
2009-07-17 12:59                           ` [PATCH 2/2 v4] " Wolfgang Denk
2009-07-17 14:45                             ` Grant Likely
2009-07-17 17:51                               ` Wolfgang Denk
2009-07-17 18:31                                 ` Grant Likely
2009-07-16 21:42                       ` [PATCH 2/2 v2] " Wolfgang Denk
2009-07-16 22:48                         ` Grant Likely
2009-07-17 12:25                           ` Wolfgang Denk
2009-07-17  9:47                         ` Wolfram Sang
2009-07-17 12:35                           ` Wolfgang Denk
2009-07-15 15:18                     ` [PATCH 2/2] " Wolfgang Denk
2009-07-15 17:18                       ` Grant Likely
2009-07-16 21:21                         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090607203406.7C8BC832E416@gemini.denx.de \
    --to=wd@denx.de \
    --cc=Hong-jun.chen@freecale.com \
    --cc=grant.likely@secretlab.ca \
    --cc=jcrigby@gmail.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).